Signal Proxy, in fetch(), must be protected because it can be used on main-thread and workers

RESOLVED FIXED in Firefox 59

Status

()

P2
normal
RESOLVED FIXED
10 months ago
10 months ago

People

(Reporter: baku, Assigned: baku)

Tracking

58 Branch
mozilla59
Points:
---

Firefox Tracking Flags

(firefox59 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 months ago
https://treeherder.mozilla.org/logviewer.html#?job_id=155762760&repo=try&lineNumber=4994

In WorkerFetchResolver, we use a SignalProxy in both worker and main-thread. We need to be 100% sure that when used, we don't create race conditions as this ASAN log shows.

Updated

10 months ago
Priority: -- → P2
(Assignee)

Comment 1

10 months ago
Created attachment 8942161 [details] [diff] [review]
fetch.patch

SignalProxy is already correctly used. It seems to me that the only problem is that it's nullified on the worker side. If we don't do that, we are not introducing any leak. Let's go for this simply approach (we have a similar approach for mPromiseProxy).
Attachment #8942161 - Flags: review?(bkelly)
Attachment #8942161 - Flags: review?(bkelly) → review+

Comment 2

10 months ago
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/37ac87b44ae3
Signal Proxy, in fetch(), doesn't have to be nullified in order to avoid race conditions, r=bkelly

Comment 3

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/37ac87b44ae3
Status: NEW → RESOLVED
Last Resolved: 10 months ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
1 failures in 788 pushes (0.001 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* try: 1

Platform breakdown:
* linux64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1430061&startday=2018-01-08&endday=2018-01-14&tree=all
You need to log in before you can comment on or make changes to this bug.