https://treeherder.mozilla.org/logviewer.html#?job_id=155762760&repo=try&lineNumber=4994 In WorkerFetchResolver, we use a SignalProxy in both worker and main-thread. We need to be 100% sure that when used, we don't create race conditions as this ASAN log shows.
SignalProxy is already correctly used. It seems to me that the only problem is that it's nullified on the worker side. If we don't do that, we are not introducing any leak. Let's go for this simply approach (we have a similar approach for mPromiseProxy).
Attachment #8942161 - Flags: review?(bkelly)
Attachment #8942161 - Flags: review?(bkelly) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/37ac87b44ae3 Signal Proxy, in fetch(), doesn't have to be nullified in order to avoid race conditions, r=bkelly
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.