Open Bug 1430062 Opened 6 years ago Updated 2 years ago

Add automated tests for customize mode dragging items in RTL locales

Categories

(Firefox :: Toolbars and Customization, enhancement, P3)

57 Branch
enhancement

Tracking

()

People

(Reporter: Gijs, Unassigned)

References

Details

(Keywords: rtl)

(In reply to Jared Wein [:jaws] (please needinfo? me) from bug 1426250 comment #14)
> Comment on attachment 8941006 [details]
> Bug 1426250 - make tests actually pass valid mouse coordinates when testing
> Customize Mode,
> 
> https://reviewboard.mozilla.org/r/211294/#review217918
> 
> ::: browser/components/customizableui/test/head.js:183
> (Diff revision 1)
> > +    if (ev == "end") {
> > +      ev = {clientX: bounds.right - 2, clientY: bounds.bottom - 2};
> > +    } else {
> > +      ev = {clientX: bounds.left + 2, clientY: bounds.top + 2};
> 
> The names are "start" and "end" but this doesn't account for RTL, and most
> likely most of our tests don't either but I figure I should point it out.
> Should we add one test that does a RTL drag/drop so we have some test
> coverage there? You can do a follow-up for this if you'd like.

This is a good idea. We've had RTL-only bugs before and are always late to notice them.
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.