Add readmoo to searchplugins shipping in Firefox desktop

RESOLVED FIXED in Firefox 60

Status

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: irvin, Assigned: flod)

Tracking

unspecified
mozilla60

Firefox Tracking Flags

(firefox60 fixed)

Details

Attachments

(3 attachments)

Hi,

We'd ship Findbook.tw as search plugin as replacement of Amazon since Firefox 3.0 on zh-TW build *1, however, the service seems on halt since 2015. 

After the discussion *2, we think it's better to replace it with either Taaze.tw or Readmoo (https://readmoo.com/), two online bookstore services.

We already removed Findbook searchplugin in bug 1411616.


However, on bug 1411597, we're unable to get response from Taaze's staff for more than one month. So we're switch to our next choice - Readmoo now. We had also got the initial agreement to proceed from Readmoo's staff,
https://groups.google.com/d/msg/moztw-general/-V2T39FG-OE/LL3gNVjhAwAJ


Here is the search plugin from Readmoo (uploaded by Readmoo themself), https://addons.mozilla.org/zh-TW/firefox/addon/readmoo-%E8%AE%80%E5%A2%A8%E9%9B%BB%E5%AD%90%E6%9B%B8/


:flod, :joanne, do we proceed from requesting the same infos of 1411597#c13 ?


1) related local community discussion from 2008,
   https://forum.moztw.org/viewtopic.php?t=21612
   https://groups.google.com/d/msg/moztw-dev/dtcadsq_QAs/PV4endaGLZYJ

2) https://groups.google.com/forum/#!msg/moztw-general/-V2T39FG-OE/
The info we was requesting from Taaze on bug 1411597#c13

* Legal Name of Provider's Search Service
* Address
* Address
* Address
* Signatory's Name and Title
* Provider's Contact Person for Implementation:
- Name
- email address
- phone number
Flags: needinfo?(jnagel)
:flod, can we also assign you to this bug?
Flags: needinfo?(francesco.lodolo)
The info requested is the same (no need to NI Joanne). Please assign the bug once we have approval.

Are there more recent discussions about this? 2008 is a really long time ago, and the second link is not open.
Flags: needinfo?(jnagel)
Flags: needinfo?(francesco.lodolo)
Hi :flod, perhaps I paste the wrong link. 

Here is the public link to response from Readmoo's staff, indicated that they support the effort, 
https://groups.google.com/d/msg/moztw-general/-V2T39FG-OE/LWFLKyHyAwAJ

I'll proceed to request the info from them. Thanks.
Assignee: petercpg → irvin
:flod, here are the required info, 


* Legal Name of Provider's Search Service
eCrowd Media, Inc.

* Address
4F., No.247, Sec. 3, Zhongxiao E. Rd.
Da’an Dist., Taipei City 106
Taiwan (R.O.C.)

* Signatory's Name and Title
Sophie Pang, CEO

* Provider's Contact Person for Implementation:
Name: Steve Huang
email: steve@ecrowdmedia.com
phone: +886-2-27528616#8304
Flags: needinfo?(francesco.lodolo)
Redirecting to Joanne.
Flags: needinfo?(francesco.lodolo) → needinfo?(jnagel)
Hi, I am filling out the short form agreement and just wanted to be sure I have the provider's service identified correctly. Is it Readmoo.com or Readmoo.tw?  I just need that clarified and I'll have the form reviewed by legal, then will attach to this bug - end of week at the latest.  Thanks for your patience! Joanne
Flags: needinfo?(jnagel) → needinfo?(irvin)
Hi Joanne, it's Readmoo.com
Flags: needinfo?(irvin) → needinfo?(jnagel)
Please have the CEO of eCrowdMedia sign and send the executed agreement to us as a .pdf.  Thanks!
Flags: needinfo?(jnagel) → needinfo?(irvin)
here is the signed document, thanks.
Flags: needinfo?(irvin) → needinfo?(jnagel)
Thanks, I have provided the executed agreement to Legal.  Please go ahead with adding the Readmoo plugin if you have not already done so.
Flags: needinfo?(jnagel) → needinfo?(irvin)
Thanks Joanne, taking over the bug.

I see they have a suitable favicon (16px+32px)
view-source:https://cdn.readmoo.com/favicon.ico

And they expose a searchplugin that I can use as base
https://cdn.readmoo.com/opensearch/store.xml
Assignee: irvin → francesco.lodolo
Flags: needinfo?(irvin)
A few notes on the patch: 

1) Searchplugin is available for testing here: https://l10n.mozilla-community.org/~flod/testsp/

2) Icon is the same used in https://cdn.readmoo.com/favicon.ico but optimized (2k vs 6k)

3) I've used this as a base
https://cdn.readmoo.com/opensearch/store.xml

but dropped the suggestions. I don't think it's a problem, given we display them only for the default search engine. 

The URL used in the XML file returns an Invalid API key error
https://api.readmoo.com/v2/books?suggest={searchTerms}&count=50

The URL used in the website's input field doesn't have a suitable format
https://readmoo.com/search/suggest?keyword=King

e.g. compare with Wikipedia
https://en.wikipedia.org/w/api.php?action=opensearch&search=king
This will require a server side change to add this to the zh-TW list as well.

When this is first added, users won't see it until we make that change.
Comment on attachment 8950894 [details]
Bug 1430075 - Add readmoo to searchplugins shipping in Firefox desktop

https://reviewboard.mozilla.org/r/220150/#review226042
Attachment #8950894 - Flags: review?(mozilla) → review+
(In reply to Mike Kaply [:mkaply] from comment #15)
> This will require a server side change to add this to the zh-TW list as well.

Is this the case only for specific locales, or for all locales? I'm afraid list.json and server might get easily out of sync.
> Is this the case only for specific locales, or for all locales? I'm afraid list.json and server might get easily out of sync.

Specific locales right now. Other locales as business needs change.

It is going to be a little messy going forward. Hoping to improve that later in the year.
Pushed by francesco.lodolo@mozillaitalia.org:
https://hg.mozilla.org/integration/autoland/rev/4eab912e9f42
Add readmoo to searchplugins shipping in Firefox desktop r=mkaply
https://hg.mozilla.org/mozilla-central/rev/4eab912e9f42
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.