1430130 - [Intermittent] Top Sites appear back in their original positions for a fraction of a second when they are moved

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Attachment: Top Sites flash back to their original position.mov

[Affected versions]:
- Firefox 59.0a1 Build ID 20180111220102

[Affected Platforms]:
- All Windows
- All Mac
- All Linux

[Prerequisites]:
- Have a clean new profile.

[Steps to reproduce]:
1. Start the browser with the profile from prerequisites and open a new profile.
2. Drag and drop a Top Site to different positions (at least 5).
3. Observe the Top Site as it is dropped in each new position.
 
[Expected results]:
- The Top Site remains in that position.

[Actual results]:
- The top site will occasionally move back to its original position for a fraction of a second.

[Notes]:
- Attached a screen recording of the issue.

Comment 1

[Ed Lee :Mardak]

Bug 1428356 fixed a similar issue with holes but this is different.

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/3938

Comment 3

[Ricky Rosario [:rrosario, :r1cky]]

Stealing back.

Comment 4

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/3939

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/40ef01636dba346c9848db742cfcbf4a10e81035
fix(topsites): Avoid flickering to original state after drop (#3938)

Fix Bug 1430130 - Top Sites appear back in their original positions for a fraction of a second when they are moved

Comment 6

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/8ae1faf4646f

Comment 7

[Ciprian Muresan [:cmuresan], Ecosystem QA]

I have verified that the issue is no longer reproducible on the latest Nightly build (Build ID 	20180121220252) using Windows 10 x64, Mac 10.12 and Ubuntu 14.04.