Closed Bug 1430145 Opened 2 years ago Closed 2 years ago

Add telemetry to record the number of module scripts loaded

Categories

(Core :: DOM: Core & HTML, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: jonco, Assigned: jonco)

References

Details

Attachments

(2 files, 2 obsolete files)

We should add telemetry so that we can see how much JS modules are being used on the web.
Priority: -- → P3
Attached patch bug1430145-script-kind-telemetry (obsolete) — Splinter Review
Patch to add telemetry to tell us the proportion of classic scripts to module scripts executed on the web.
Attachment #8942690 - Flags: review?(amarchesini)
Attached file telemetry-script-kind.txt (obsolete) —
Request for data collection review form
Attachment #8942703 - Flags: review?(liuche)
Attachment #8942690 - Flags: review?(amarchesini) → review+
> Please provide a general description of how you will analyze this data.

> Not really an analysis, I simply intend monitor the uptake of this feature on the web.

Since you don't have a plan of analysis for this or a compelling reason for why this should be monitored permanently, this does not seem like a "permanently monitor" type of probe.

Please either make a more concrete case for why this should be monitored permanently and/or provide an analysis plan, or add an expiry for this probe.

From out data policies:
https://wiki.mozilla.org/Firefox/Data_Collection

> Necessity - We collect only as much data as is necessary when we can demonstrate a clear business case for that data
Flags: needinfo?(jcoppeard)
Comment on attachment 8942703 [details]
telemetry-script-kind.txt

Please reflag me for review when ready.
Attachment #8942703 - Flags: review?(liuche) → review-
Updated patch with expires_in_version set to 63.
Attachment #8942690 - Attachment is obsolete: true
Flags: needinfo?(jcoppeard)
Attachment #8943193 - Flags: review+
Updated form with 6 month expiry.
Attachment #8942703 - Attachment is obsolete: true
Attachment #8943194 - Flags: review?(liuche)
Comment on attachment 8943194 [details]
telemetry-script-kind.txt v2

data-review only

> Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate? (see here, here, and here for examples). Refer to the appendix for "documentation" if more detail about documentation standards is needed.

Yes, Histograms


> Is there a control mechanism that allows the user to turn the data collection on and off? (Note, for data collection not needed for security purposes, Mozilla provides such a control mechanism) Provide details as to the control mechanism available.

Yes, Firefox data controls

> If the request is for permanent data collection, is there someone who will monitor the data over time?**

6mo, jonco

> Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under? **

Type 2, Type 1

> Is the data collection request for default-on or default-off?

default on

> Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
No

> Is the data collection covered by the existing Firefox privacy notice?
Yes

> Does there need to be a check-in in the future to determine whether to renew the data? (Yes/No) (If yes, set a todo reminder or file a bug if appropriate)**
Expires in 63
Attachment #8943194 - Flags: review?(liuche) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/677044553e31
Add telemetry for script kind. r=baku, data-review=liuche
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/677044553e31
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.