1430171 - Can't see the whole shortcut table if the browser isn't tall enough

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Resize your browser height down to ~800px which is a pretty reasonable height.
Press '?' to open the shortcut help panel

Expected: can see the whole thing, or scroll to see the whole thing
Actual: it's cut off and you can't scroll

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3129

Comment 4

[Phil Ringnalda (:philor)]

Note bug 1419919 comment 0

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8942254 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3129

This is ready for review, btw

Comment 6

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/6a10bdf674889a124bf376843b98e7e69f67a4dd
Bug 1430171 - Allow scrolling the shortcut table when viewing on smaller screens

Comment 7

[Jonathan French (:jfrench)]

This fix (scrollbar) got undesirably propagated to the static table available in the User Guide at https://treeherder.mozilla.org/userguide.html, instead of just being applied only to the onscreen overlay version. I would pose this should get fixed in the User Guide so it doesn't have a scroll bar.

Comment 8

[Cameron Dawson [:camd]]

Hmm, good catch.  And it seems like it resizes in the userguide.html more than it should because the size is relative to the container.  My bad for not catching that.  But yeah, this would be good to fix.  I opened bug 1434456 for this.  Would you be up for a fix?  :)

Comment 9

[Jonathan French (:jfrench)]

I'll keep it on my 'on-deck' list of things to fix :) If someone gets to it first, that's cool too.