Closed Bug 1430213 Opened 5 years ago Closed 5 years ago

Pref toggle for RTCRtpReceiver getContributingSources and getSynchronizationSources APIs

Categories

(Core :: WebRTC, enhancement, P1)

Product:
Core
Component:
WebRTC
Platform:
All
Unspecified
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla59
Tracking Flags:
Tracking Status
firefox59 --- fixed

People

(Reporter: ng, Assigned: ng)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

Bug 1430213 - add toggle pref for RTCRtpReceiver RTP sources APIs;
59 bytes, text/x-review-board-request
jib
: review+
Details 
The 2018/1/11 w3C TPAC interim, brought changes to the RTCRtpReceiver's getSynchronizationSources, and getContributingSources APIs that were recently added and are currently in Beta. We need to pref our implementation off for 59 so that those changes can be implemented, and landed in 60. A new preference "media.peerconnection.rtpsourcesapi.enable" is to be used for this.
There are a few more days than I thought, so this bug is just to add the pref which will default to enabling the API. If the required changes can not be made in time, this pref can be used to disable the APIs.
Comment on attachment 8942299 [details]
Bug 1430213 - add toggle pref for RTCRtpReceiver RTP sources APIs;

https://reviewboard.mozilla.org/r/212584/#review218286

Lgtm. Don't forget DOM review.

::: commit-message-8460d:1
(Diff revision 2)
> +Bug - 1430213 - pref off RTCRtpReceiver RTP sources APIs;r?jib

Update commit message since we're no longer preffing off immediately.
Attachment #8942299 - Flags: review?(jib) → review+
Summary: Pref off RTCRtpReceiver getContributingSources and getSynchronizationSources APIs until it can be brought up to spec → Pref toggle for RTCRtpReceiver getContributingSources and getSynchronizationSources APIs
WebIDL review info: this patch contains a new pref that will allow us to toggle support for getContributingSources and getSynchronizationSources
Comment on attachment 8942299 [details]
Bug 1430213 - add toggle pref for RTCRtpReceiver RTP sources APIs;

https://reviewboard.mozilla.org/r/212584/#review219880
Attachment #8942299 - Flags: review+
hg error in cmd: hg push -r tip ssh://hg.mozilla.org/integration/autoland: pushing to ssh://hg.mozilla.org/integration/autoland
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 1 changesets with 3 changes to 3 files
remote: 
remote: 
remote: ************************** ERROR ****************************
remote: Rev 1d4fe98db80e needs "Bug N" or "No bug" in the commit message.
remote: Nico Grunbaum
remote: Bug - 1430213 - add toggle pref for RTCRtpReceiver RTP sources APIs;r=jib,smaug
remote: 
remote: MozReview-Commit-ID: 7vKUDDpjiP2
remote: *************************************************************
remote: 
remote: 
remote: transaction abort!
remote: rollback completed
remote: pretxnchangegroup.c_commitmessage hook failed
abort: push failed on remote
Pushed by na-g@nostrum.com:
https://hg.mozilla.org/integration/autoland/rev/a228b6c6b7aa
add toggle pref for RTCRtpReceiver RTP sources APIs;r=jib,smaug
https://hg.mozilla.org/mozilla-central/rev/a228b6c6b7aa
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Documentation updated; this is now marked as disabled by default with info on the pref.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.