Closed Bug 1430277 Opened 8 years ago Closed 8 years ago

make check fails when building with --enable-strip

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox59 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla59
Tracking Flags:
Tracking Status
firefox59 --- fixed

People

(Reporter: glandium, Assigned: glandium)

Details

Attachments

(1 file)

Bug 1430277 - Skip symbolstore.py test when building with --enable-strip.
59 bytes, text/x-review-board-request
mshal
: review+
Details
[task 2018-01-12T22:08:44.507Z] 22:08:44 WARNING - ../toolkit/crashreporter/tools/unit-symbolstore.py::TestFunctional::testSymbolstore TEST-UNEXPECTED-FAIL [task 2018-01-12T22:08:44.507Z] 22:08:44 INFO - =================================== FAILURES =================================== [task 2018-01-12T22:08:44.508Z] 22:08:44 INFO - ________________________ TestFunctional.testSymbolstore ________________________ [task 2018-01-12T22:08:44.508Z] 22:08:44 INFO - self = <unit-symbolstore.TestFunctional testMethod=testSymbolstore> [task 2018-01-12T22:08:44.508Z] 22:08:44 INFO - def testSymbolstore(self): [task 2018-01-12T22:08:44.508Z] 22:08:44 INFO - if self.skip_test: [task 2018-01-12T22:08:44.508Z] 22:08:44 INFO - raise unittest.SkipTest('Skipping test in non-Firefox product') [task 2018-01-12T22:08:44.508Z] 22:08:44 INFO - dist_include_manifest = os.path.join(buildconfig.topobjdir, [task 2018-01-12T22:08:44.509Z] 22:08:44 INFO - '_build_manifests/install/dist_include') [task 2018-01-12T22:08:44.509Z] 22:08:44 INFO - dist_include = os.path.join(buildconfig.topobjdir, 'dist/include') [task 2018-01-12T22:08:44.509Z] 22:08:44 INFO - output = subprocess.check_output([sys.executable, [task 2018-01-12T22:08:44.509Z] 22:08:44 INFO - self.script_path, [task 2018-01-12T22:08:44.509Z] 22:08:44 INFO - '--vcs-info', [task 2018-01-12T22:08:44.509Z] 22:08:44 INFO - '-s', self.topsrcdir, [task 2018-01-12T22:08:44.510Z] 22:08:44 INFO - '--install-manifest=%s,%s' % (dist_include_manifest, [task 2018-01-12T22:08:44.510Z] 22:08:44 INFO - dist_include), [task 2018-01-12T22:08:44.510Z] 22:08:44 INFO - self.dump_syms, [task 2018-01-12T22:08:44.510Z] 22:08:44 INFO - self.test_dir, [task 2018-01-12T22:08:44.510Z] 22:08:44 INFO - self.target_bin], [task 2018-01-12T22:08:44.510Z] 22:08:44 INFO - stderr=open(os.devnull, 'w')) [task 2018-01-12T22:08:44.511Z] 22:08:44 INFO - lines = filter(lambda x: x.strip(), output.splitlines()) [task 2018-01-12T22:08:44.511Z] 22:08:44 INFO - self.assertEqual(1, len(lines), [task 2018-01-12T22:08:44.511Z] 22:08:44 INFO - 'should have one filename in the output') [task 2018-01-12T22:08:44.511Z] 22:08:44 INFO - symbol_file = os.path.join(self.test_dir, lines[0]) [task 2018-01-12T22:08:44.511Z] 22:08:44 INFO - self.assertTrue(os.path.isfile(symbol_file)) [task 2018-01-12T22:08:44.511Z] 22:08:44 INFO - symlines = open(symbol_file, 'r').readlines() [task 2018-01-12T22:08:44.512Z] 22:08:44 INFO - file_lines = [l for l in symlines if l.startswith('FILE')] [task 2018-01-12T22:08:44.512Z] 22:08:44 INFO - def check_hg_path(lines, match): [task 2018-01-12T22:08:44.512Z] 22:08:44 INFO - match_lines = [l for l in file_lines if match in l] [task 2018-01-12T22:08:44.512Z] 22:08:44 INFO - self.assertTrue(len(match_lines) >= 1, [task 2018-01-12T22:08:44.512Z] 22:08:44 INFO - 'should have a FILE line for ' + match) [task 2018-01-12T22:08:44.512Z] 22:08:44 INFO - # Skip this check for local git repositories. [task 2018-01-12T22:08:44.512Z] 22:08:44 INFO - if not os.path.isdir(mozpath.join(self.topsrcdir, '.hg')): [task 2018-01-12T22:08:44.513Z] 22:08:44 INFO - return [task 2018-01-12T22:08:44.513Z] 22:08:44 INFO - for line in match_lines: [task 2018-01-12T22:08:44.513Z] 22:08:44 INFO - filename = line.split(None, 2)[2] [task 2018-01-12T22:08:44.513Z] 22:08:44 INFO - self.assertEqual('hg:', filename[:3]) [task 2018-01-12T22:08:44.513Z] 22:08:44 INFO - # Check that nsBrowserApp.cpp is listed as a FILE line, and that [task 2018-01-12T22:08:44.513Z] 22:08:44 INFO - # it was properly mapped to the source repo. [task 2018-01-12T22:08:44.514Z] 22:08:44 INFO - > check_hg_path(file_lines, 'nsBrowserApp.cpp') [task 2018-01-12T22:08:44.514Z] 22:08:44 INFO - ../toolkit/crashreporter/tools/unit-symbolstore.py:534: [task 2018-01-12T22:08:44.514Z] 22:08:44 INFO - _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ [task 2018-01-12T22:08:44.514Z] 22:08:44 INFO - ../toolkit/crashreporter/tools/unit-symbolstore.py:525: in check_hg_path [task 2018-01-12T22:08:44.514Z] 22:08:44 INFO - 'should have a FILE line for ' + match) [task 2018-01-12T22:08:44.514Z] 22:08:44 INFO - E AssertionError: should have a FILE line for nsBrowserApp.cpp [task 2018-01-12T22:08:44.514Z] 22:08:44 INFO - ===================== 1 failed, 11 passed in 0.39 seconds ======================
Comment on attachment 8942357 [details] Bug 1430277 - Skip symbolstore.py test when building with --enable-strip. https://reviewboard.mozilla.org/r/212644/#review218922
Attachment #8942357 - Flags: review+
Attachment #8942357 - Flags: review?(core-build-config-reviews)
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/b0a019ba2ade Skip symbolstore.py test when building with --enable-strip. r=mshal
https://hg.mozilla.org/mozilla-central/rev/b0a019ba2ade
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: