Closed Bug 14303 Opened 25 years ago Closed 25 years ago

Select bustage: cut or delete error leads to option used before set error

Categories

(Core :: Layout: Form Controls, defect, P3)

defect

Tracking

()

VERIFIED FIXED

People

(Reporter: brendan, Assigned: pollmann)

References

()

Details

Some code earlier in the function seems to have been lost (near the for loop top
option should be set; it's not).

Windows warns about this -- I wish it were an error.  Let's be careful out there
and stuff!

/be
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Target Milestone: M11
That typo was part of a huge update of nsNativeSelectControlFrame.  Yikes!

I checked in a fix.  This is a code level fix and is not (easily) verifiable by
running the program.  To verify the fix, visit the URL above in this bug.  You
will notice that there is no longer a reference to the uninitialized variable
'option'  (option->GetSelected was replaced with GetOptionSelectedCache).
Status: RESOLVED → VERIFIED
Line 998 just has a comment on it... but it seems that this must be fixed, yes?
Marking verified.
You need to log in before you can comment on or make changes to this bug.