Closed Bug 1430315 Opened 2 years ago Closed 2 years ago

llvm-dsymutil crash with rust 1.23.0 on macos opt build

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox59 fixed)

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: rillian, Assigned: glandium)

References

Details

Attachments

(3 files)

Another crash with llvm-dsymutil, this with with the release builds with rust 1.23.0.

> Error running dsymutil: Command '[u'/builds/worker/workspace/build/src/clang/bin/llvm-dsymutil', '--arch=x86_64', '/builds/worker/workspace/build/src/obj-firefox/toolkit/library/XUL']' returned non-zero exit status -11
Attached file llvm-dsymutil.log
Looks like the infinite name loop again. What do you think, Ted?
Flags: needinfo?(ted)
I'll take a look at this next week. A good occasion to write a doc (or a script) at the same time.
Flags: needinfo?(mh+mozilla)
Assignee: nobody → mh+mozilla
Flags: needinfo?(mh+mozilla)
Comment on attachment 8943056 [details]
Bug 1430315 - Add a toolchain job to build llvm-dsymutil independently.

https://reviewboard.mozilla.org/r/213322/#review219070

::: taskcluster/ci/toolchain/linux.yml:183
(Diff revision 1)
> +        platform: toolchains/opt
> +        symbol: TL(dsymutil)
> +        tier: 1
> +    worker-type: aws-provisioner-v1/gecko-{level}-b-linux
> +    worker:
> +        max-run-time: 36000

If we're just building llvm-dsymutil we probably don't need 10 hours. Maybe 7200 or 14400?
Attachment #8943056 - Flags: review+
Comment on attachment 8943057 [details]
Bug 1430315 - Use the separate llvm-dsymutil toolchain to build Firefox.

https://reviewboard.mozilla.org/r/213324/#review219072

Does the macosx64-searcfox task need to use this too?
Attachment #8943057 - Flags: review+
Attachment #8943056 - Flags: review?(core-build-config-reviews)
Attachment #8943057 - Flags: review?(core-build-config-reviews)
(In reply to Ralph Giles (:rillian) | needinfo me from comment #7)
> Comment on attachment 8943057 [details]
> Bug 1430315 - Use the separate llvm-dsymutil toolchain to build Firefox.
> 
> https://reviewboard.mozilla.org/r/213324/#review219072
> 
> Does the macosx64-searcfox task need to use this too?

I don't know, and it's busted for some other reason, so I can't tell.
(In reply to Ralph Giles (:rillian) | needinfo me from comment #6)
> Comment on attachment 8943056 [details]
> Bug 1430315 - Add a toolchain job to build llvm-dsymutil independently.
> 
> https://reviewboard.mozilla.org/r/213322/#review219070
> 
> ::: taskcluster/ci/toolchain/linux.yml:183
> (Diff revision 1)
> > +        platform: toolchains/opt
> > +        symbol: TL(dsymutil)
> > +        tier: 1
> > +    worker-type: aws-provisioner-v1/gecko-{level}-b-linux
> > +    worker:
> > +        max-run-time: 36000
> 
> If we're just building llvm-dsymutil we probably don't need 10 hours. Maybe
> 7200 or 14400?

Actually it takes less than 10 minutes, so let's go with 1800.
(In reply to Mike Hommey [:glandium] from comment #8)
> (In reply to Ralph Giles (:rillian) | needinfo me from comment #7)
> > Comment on attachment 8943057 [details]
> > Bug 1430315 - Use the separate llvm-dsymutil toolchain to build Firefox.
> > 
> > https://reviewboard.mozilla.org/r/213324/#review219072
> > 
> > Does the macosx64-searcfox task need to use this too?
> 
> I don't know, and it's busted for some other reason, so I can't tell.

... but probably.
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/aee6cb0464d7
Add a toolchain job to build llvm-dsymutil independently. r=rillian
https://hg.mozilla.org/integration/autoland/rev/fb5c087381a6
Use the separate llvm-dsymutil toolchain to build Firefox. r=rillian
https://hg.mozilla.org/mozilla-central/rev/aee6cb0464d7
https://hg.mozilla.org/mozilla-central/rev/fb5c087381a6
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Pushed by mozilla@hocat.ca:
https://hg.mozilla.org/comm-central/rev/5d90cec1e409
Port Bug 1430315: Use the separate llvm-dsymutil toolchain to build Thunderbird; rs=bustage-fix
Blocks: 1429056
Flags: needinfo?(ted)
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.