1430315 - llvm-dsymutil crash with rust 1.23.0 on macos opt build

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Ralph Giles (:rillian)]

Another crash with llvm-dsymutil, this with with the release builds with rust 1.23.0.

> Error running dsymutil: Command '[u'/builds/worker/workspace/build/src/clang/bin/llvm-dsymutil', '--arch=x86_64', '/builds/worker/workspace/build/src/obj-firefox/toolkit/library/XUL']' returned non-zero exit status -11

Comment 1

[Ralph Giles (:rillian)]

Attachment: llvm-dsymutil.log

Looks like the infinite name loop again. What do you think, Ted?

Comment 2

[Mike Hommey [:glandium]]

I'll take a look at this next week. A good occasion to write a doc (or a script) at the same time.

Comment 3

[Ralph Giles (:rillian)]

This seems to be intermittent.

Failure: https://treeherder.mozilla.org/#/jobs?repo=try&author=[e-mail]&selectedJob=155907157

Success: https://treeherder.mozilla.org/#/jobs?repo=try&author=[e-mail]&selectedJob=156067224

Rebased on different versions of m-c.

Comment 4

[Mike Hommey [:glandium]]

Attachment: Bug 1430315 - Add a toolchain job to build llvm-dsymutil independently.

We've had problems with crashes in llvm-dsymutil for a while, and while
they are, in essence, due to the fact that rustc produces bad debug
info, they are a hurdle to our builds. The tool comes along clang, and
updating clang is not necessarily easy (witness bug 1409265), so, so
far, we've relied on backporting fixes, which can be time confusing
(witness bug 1410148).

OTOH, llvm-dsymutil is a rather specific tool, that doesn't strictly
need to be tied to clang. It's only tied to it because it uses the llvm
code to do some of the things it does, and it's part of the llvm source
tree. But it could just as well be a separate tool, like it was(is?) on
OSX.

So, we add a toolchain job to build it from the llvm source,
independently from clang, so that we can update it separately, if we
hit new crashes that happen to already be fixed on llvm trunk. It will
also allow to more easily update after upstream fixes crashes after we
report them.

Review commit: https://reviewboard.mozilla.org/r/213322/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/213322/

Comment 5

[Mike Hommey [:glandium]]

Attachment: Bug 1430315 - Use the separate llvm-dsymutil toolchain to build Firefox.

Review commit: https://reviewboard.mozilla.org/r/213324/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/213324/

Comment 6

[Ralph Giles (:rillian)]

Comment on attachment 8943056 [details]
Bug 1430315 - Add a toolchain job to build llvm-dsymutil independently.

https://reviewboard.mozilla.org/r/213322/#review219070

::: taskcluster/ci/toolchain/linux.yml:183
(Diff revision 1)
> +        platform: toolchains/opt
> +        symbol: TL(dsymutil)
> +        tier: 1
> +    worker-type: aws-provisioner-v1/gecko-{level}-b-linux
> +    worker:
> +        max-run-time: 36000

If we're just building llvm-dsymutil we probably don't need 10 hours. Maybe 7200 or 14400?

Comment 7

[Ralph Giles (:rillian)]

Comment on attachment 8943057 [details]
Bug 1430315 - Use the separate llvm-dsymutil toolchain to build Firefox.

https://reviewboard.mozilla.org/r/213324/#review219072

Does the macosx64-searcfox task need to use this too?

Comment 8

[Mike Hommey [:glandium]]

(In reply to Ralph Giles (:rillian) | needinfo me from comment #7)
> Comment on attachment 8943057 [details]
> Bug 1430315 - Use the separate llvm-dsymutil toolchain to build Firefox.
> 
> https://reviewboard.mozilla.org/r/213324/#review219072
> 
> Does the macosx64-searcfox task need to use this too?

I don't know, and it's busted for some other reason, so I can't tell.

Comment 9

[Mike Hommey [:glandium]]

(In reply to Ralph Giles (:rillian) | needinfo me from comment #6)
> Comment on attachment 8943056 [details]
> Bug 1430315 - Add a toolchain job to build llvm-dsymutil independently.
> 
> https://reviewboard.mozilla.org/r/213322/#review219070
> 
> ::: taskcluster/ci/toolchain/linux.yml:183
> (Diff revision 1)
> > +        platform: toolchains/opt
> > +        symbol: TL(dsymutil)
> > +        tier: 1
> > +    worker-type: aws-provisioner-v1/gecko-{level}-b-linux
> > +    worker:
> > +        max-run-time: 36000
> 
> If we're just building llvm-dsymutil we probably don't need 10 hours. Maybe
> 7200 or 14400?

Actually it takes less than 10 minutes, so let's go with 1800.

Comment 10

[Mike Hommey [:glandium]]

(In reply to Mike Hommey [:glandium] from comment #8)
> (In reply to Ralph Giles (:rillian) | needinfo me from comment #7)
> > Comment on attachment 8943057 [details]
> > Bug 1430315 - Use the separate llvm-dsymutil toolchain to build Firefox.
> > 
> > https://reviewboard.mozilla.org/r/213324/#review219072
> > 
> > Does the macosx64-searcfox task need to use this too?
> 
> I don't know, and it's busted for some other reason, so I can't tell.

... but probably.

Comment 11

[Mike Hommey [:glandium]]

Comment on attachment 8943056 [details]
Bug 1430315 - Add a toolchain job to build llvm-dsymutil independently.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/213322/diff/1-2/

Comment 12

[Mike Hommey [:glandium]]

Comment on attachment 8943057 [details]
Bug 1430315 - Use the separate llvm-dsymutil toolchain to build Firefox.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/213324/diff/1-2/

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aee6cb0464d7
Add a toolchain job to build llvm-dsymutil independently. r=rillian
https://hg.mozilla.org/integration/autoland/rev/fb5c087381a6
Use the separate llvm-dsymutil toolchain to build Firefox. r=rillian

Comment 14

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/aee6cb0464d7
https://hg.mozilla.org/mozilla-central/rev/fb5c087381a6

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5d90cec1e409
Port Bug 1430315: Use the separate llvm-dsymutil toolchain to build Thunderbird; rs=bustage-fix