1430319 - Get rid of nsIEditActionListener::Will*()

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

After fixing bug 1430021, nobody listens to nsIEditActionListener::Will*(). So, we can just remove them simply.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0cc7f4efe12889bb797ff074955303759579f7c9

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=eb2e394864ef360f993519f134e3b21d949a322e

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Unfortunately, we cannot remove WillDeleteText, WillDeleteSelection nor DidInsertText because FinderHighlighter.jsm implements them:
https://searchfox.org/mozilla-central/rev/41925c0b6c6d58578690121de439d2a8d3d690f3/toolkit/modules/FinderHighlighter.jsm#1495,1516,1542

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=08cf76285d2960777ea00ea86e7e607fde43096b

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1430319 - Get rid of nsIEditActionListener::Will*() which are not used by anybody

Most nsIEditActionListener::Will*() are not implemented, except
WillDeleteText() and WillDeleteSelection() which are implemented by
FinderHighlighter.  So, we can get rid of the other Will*() from it.

This patch removes a lot of unnecessary virtual calls and copy of strong
pointers to edit action listeners of EditorBase.

Review commit: https://reviewboard.mozilla.org/r/213174/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/213174/

Comment 6

[Makoto Kato [:m_kato]]

Comment on attachment 8942911 [details]
Bug 1430319 - Get rid of nsIEditActionListener::Will*() which are not used by anybody

https://reviewboard.mozilla.org/r/213174/#review219574

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/837df5c8fac8
Get rid of nsIEditActionListener::Will*() which are not used by anybody r=m_kato

Comment 8

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/837df5c8fac8