Closed
Bug 1430329
Opened 8 years ago
Closed 8 years ago
StyleSheetActor.update unnecessarily emits ruleCount change event when handling UPDATE_PRESERVING_RULES
Categories
(DevTools :: Inspector: Rules, enhancement)
DevTools
Inspector: Rules
Tracking
(firefox59 fixed)
RESOLVED
FIXED
Firefox 59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: bradwerth, Assigned: bradwerth)
Details
Attachments
(1 file)
The UPDATE_PRESERVING_RULES const indicates that the number and order of rules are unchanged. StyleSheetActor.update should be checking this when determining whether or not to emit a ruleCount change event.
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•8 years ago
|
Attachment #8942394 -
Flags: review?(ttromey)
|
||
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8942394 [details]
Bug 1430329: Make StyleSheetActor.update only emit ruleCount change events when necessary.
https://reviewboard.mozilla.org/r/212692/#review218554
Thank you for the patch. This seems like a completely reasonable idea to me.
Attachment #8942394 -
Flags: review?(ttromey) → review+
Pushed by bwerth@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/07bdc1156ee2
Make StyleSheetActor.update only emit ruleCount change events when necessary. r=tromey
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•