StyleSheetActor.update unnecessarily emits ruleCount change event when handling UPDATE_PRESERVING_RULES

RESOLVED FIXED in Firefox 59

Status

enhancement
RESOLVED FIXED
2 years ago
Last year

People

(Reporter: bradwerth, Assigned: bradwerth)

Tracking

unspecified
Firefox 59

Firefox Tracking Flags

(firefox59 fixed)

Details

Attachments

(1 attachment)

The UPDATE_PRESERVING_RULES const indicates that the number and order of rules are unchanged. StyleSheetActor.update should be checking this when determining whether or not to emit a ruleCount change event.
Attachment #8942394 - Flags: review?(ttromey)
Comment on attachment 8942394 [details]
Bug 1430329: Make StyleSheetActor.update only emit ruleCount change events when necessary.

https://reviewboard.mozilla.org/r/212692/#review218554

Thank you for the patch.  This seems like a completely reasonable idea to me.
Attachment #8942394 - Flags: review?(ttromey) → review+
Pushed by bwerth@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/07bdc1156ee2
Make StyleSheetActor.update only emit ruleCount change events when necessary. r=tromey
https://hg.mozilla.org/mozilla-central/rev/07bdc1156ee2
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.