Closed Bug 1430353 Opened 2 years ago Closed 2 years ago

allow for an easier to read treeherder relpro symbol

Categories

(Release Engineering :: Release Automation: Other, enhancement)

enhancement
Not set

Tracking

(firefox59 fixed)

RESOLVED FIXED
Tracking Status
firefox59 --- fixed

People

(Reporter: aki, Assigned: aki)

Details

Attachments

(1 file)

Right now the treeherder symbol for any release promotion action is "Relpro". We have to click the taskId and dig into the task definition to figure if it's a promote_firefox or a push_devedition or a ship_fennec action.

We use json-e to build the task definition! Let's make the treeherder symbol dynamic.
Attached patch th-symbol.diffSplinter Review
This patch will change the release promotion action treeherder symbol from 'Relpro' to one of the `release_promotion_flavors` [1]. Tested here [2].

[1] the dictionary keys of https://hg.mozilla.org/mozilla-central/file/f5b4481c9fd5/taskcluster/taskgraph/actions/release_promotion.py#l23

[2] https://treeherder.mozilla.org/#/jobs?repo=maple&revision=8dcecea271b5236de6b7a7130de1ddb872e3a55a&filter-searchStr=decision
Attachment #8942411 - Flags: review?(bstack)
Comment on attachment 8942411 [details] [diff] [review]
th-symbol.diff

This looks great. I'm not sure what goes wrong if someone uses json-e to make the symbol >25 chars, but I expect that it just cuts off the symbol in treeherder or something?
Attachment #8942411 - Flags: review?(bstack) → review+
I'm not sure. I don't see any check in the treeherder repo, though I may be missing it. It may be a pulse or db limit.

I could:
- add a test in actions/release_promotion.py, but that only helps the one action
- test a longer symbol on maple or try to see what happens :)
- add a test somewhere else in the taskgraph gen.
If you have extra free time and want to try it out just to see what happens, may as well. Otoh, I'm not particularly scared of the consequences so feel free to land :)
Pushed by asasaki@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fa4d1e09dd1f
allow for an easier to read treeherder relpro symbol. r=bstack
https://hg.mozilla.org/mozilla-central/rev/fa4d1e09dd1f
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.