1430359 - Disable HTTP Cache does not work after use performance analysis

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P3)

Description

[magicp]

Steps to reproduce:
1. Launch Nightly
2. Open Netmonitor
3. Enable "Disable cache"
4. Go to any sites
5. Start performance analysis
6. Click "Back" button
7. Reload current page

Actual results:
"Disable cache" does not work after use performance analysis.

Expected results:
"Disable cache" works.

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thanks for the report, I can reproduce the issue using STR in comment #0
Honza

Comment 2

[Hemakshi Sachdev [:hemakshis]]

Hi!

I have a solution for this. We can again do a reload with cache disabled (if Disabled Cache is checked) while returning from the statistics panel, this way on subsequent reloads we will have the expected behaviour.

I am attaching a patch with this proposed solution. :)

Hemakshi

Comment 3

[Hemakshi Sachdev [:hemakshis]]

Attachment: Bug 1430359 - Disable HTTP Cache does not work after use of performance analysis. r=Honza

Added a condition in the openStatistics action to check if Disabled Cache is checked, if yes, do a reload with cache disabled

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Commented in Phabricator.

Honza

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3ad61ef0d62d
Disable HTTP Cache does not work after use of performance analysis. r=Honza

Comment 6

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/3ad61ef0d62d

Comment 7

[Daniel Bodea [:danibodea]]

I am attempting to verify the fix of this bug but I need some detailed information in order for me to verify it correctly.

These are the steps I took, I need some corrections and details:

1. Launch browser (latest Nightly and latest Beta should contain the fix, at this moment);
2. Open Netmonitor (CTRL+SHIFT+E on Windows);
3. Check the "Disable cache" checkbox;
4. Open random web page;
5. Clear the NetMonitor of events by the "Recycle Bin" icon;
6. Click on the "Stopwatch" icon to start performance analysis;
7. Click the "Back" button -> which back button? on the net monitor or the browser's main back button?
8. Reload the current page.

Actual results:
"Disable cache" does not work after use performance analysis. -> what exactly does that mean? how do I verify that?

Expected results:
"Disable cache" works. -> what exactly does that mean? how do I verify that?

Please help me with the information I need in order to verify this bug. Thank you.

Comment 8

[Hemakshi Sachdev [:hemakshis]]

(In reply to Bodea Daniel [:danibodea] from comment #7)

6. Click on the "Stopwatch" icon to start performance analysis;
7. Click the "Back" button -> which back button? on the net monitor or the browser's main back button?

On the netmonitor a vertical bar saying "back" on the left of the netmonitor

8. Reload the current page.

Actual results:
"Disable cache" does not work after use performance analysis. -> what exactly does that mean? how do I verify that?

Earlier when you reloaded the page, you were able to see "cached" requests which contradicts the fact that the "Disable Cache" is still checked.

Expected results:
"Disable cache" works. -> what exactly does that mean? how do I verify that?

Now after these changes, when we reload the page after coming back from the performance analysis page we are able to see fresh, non-cached requests.

Comment 9

[Daniel Bodea [:danibodea]]

This issue appears as it still occurs in Nightly v69.0a1 (2019-06-12) and Beta v68.0b9 on Windows 10.