1430421 - Add .arcconfig to comm-central

Status: RESOLVED FIXED

(Thunderbird :: Build Config, enhancement)

Description

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

comm-central needs an .arcconfig for phabricator. Adding it in this bug.

Comment 1

[Tom Prince [:tomprince]]

It is actually possible to use phabriactor without using arc. I've been using https://www.mercurial-scm.org/wiki/Phabricator along with https://phabricator.services.mozilla.com/D345 to submit reviews.

Comment 2

[Phabricator Automation]

Comment on attachment 8942460 [details]
Bug 1430421 - Add .arcconfig to comm-central. r=tomprince

Tom Prince [:tomprince] has approved the revision.

https://phabricator.services.mozilla.com/D386#9291

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Interesting. I'm kind of wary to enable more experimental/unstable features, but it seems there will be some changes to the process anyway (I read gps is not happy about arc either). Let's still keep this given it is the current recommendation. I pushed my patch using that config and it worked well.

Comment 4

[Jorg K (GMT+1) (PTO to 5th Jan 2020, sporadically reading bugmail)]

Any instructions on how to import this patch? Surely it can't be "Download Raw Diff" :-(

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

http://moz-conduit.readthedocs.io/en/latest/phabricator-user.html#landing-patches shows information about the process on how it is currently suggested, but of course a raw diff works as well if you don't want to go through installing arc.

Comment 6

[Jorg K (GMT+1) (PTO to 5th Jan 2020, sporadically reading bugmail)]

Attachment: 1430421.patch

Hmm, that states:
Landing to git repositories is simple: ... and
Manually landing to mozilla-inbound is also straightforward: check out the inbound bookmark, ... (??)
How do I check out the "inbound bookmark", besides, the patch is not for Mozilla's inbound.

Getting the raw diff and then manually creating a path from it also appears a little inconvenient compared to "hg qimport" and certainly prone to errors or omissions.

Comment 7

[Jorg K (GMT+1) (PTO to 5th Jan 2020, sporadically reading bugmail)]

Attachment: 1430421.patch

And I missed the newline at the end :-(

Comment 8

[Jorg K (GMT+1) (PTO to 5th Jan 2020, sporadically reading bugmail)]

Attachment: 1430421.patch

Sigh, looks like the author uses a different e-mail address for HG. This shows that I needed three attempts to get it right. So for the time being I suggest not to use tools which aren't fully integrated.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1cd741631051
Add .arcconfig to comm-central. r=tomprince

Comment 10

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

I'm sure with a little initial effort you'll find a quick way to do it, it is really not that complicated. As the author, I have updated my phabricator email address, so that part should be right next time.

As for the diff, setting up arcanist was fairly easy so there is that. Then you can also hg qimport https://phabricator.services.mozilla.com/D386?download=true (where the URL is copy link location from the raw diff).