Closed Bug 1430421 Opened 2 years ago Closed 2 years ago

Add .arcconfig to comm-central

Categories

(Thunderbird :: Build Config, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 59.0

People

(Reporter: Fallen, Assigned: Fallen)

References

Details

Attachments

(2 files, 2 obsolete files)

comm-central needs an .arcconfig for phabricator. Adding it in this bug.
It is actually possible to use phabriactor without using arc. I've been using https://www.mercurial-scm.org/wiki/Phabricator along with https://phabricator.services.mozilla.com/D345 to submit reviews.
Comment on attachment 8942460 [details]
Bug 1430421 - Add .arcconfig to comm-central. r=tomprince

Tom Prince [:tomprince] has approved the revision.

https://phabricator.services.mozilla.com/D386#9291
Attachment #8942460 - Flags: review+
Interesting. I'm kind of wary to enable more experimental/unstable features, but it seems there will be some changes to the process anyway (I read gps is not happy about arc either). Let's still keep this given it is the current recommendation. I pushed my patch using that config and it worked well.
Keywords: checkin-needed
Any instructions on how to import this patch? Surely it can't be "Download Raw Diff" :-(
http://moz-conduit.readthedocs.io/en/latest/phabricator-user.html#landing-patches shows information about the process on how it is currently suggested, but of course a raw diff works as well if you don't want to go through installing arc.
Attached patch 1430421.patch (obsolete) β€” β€” Splinter Review
Hmm, that states:
Landing to git repositories is simple: ... and
Manually landing to mozilla-inbound is also straightforward: check out the inbound bookmark, ... (??)
How do I check out the "inbound bookmark", besides, the patch is not for Mozilla's inbound.

Getting the raw diff and then manually creating a path from it also appears a little inconvenient compared to "hg qimport" and certainly prone to errors or omissions.
Attached patch 1430421.patch (obsolete) β€” β€” Splinter Review
And I missed the newline at the end :-(
Attachment #8942485 - Attachment is obsolete: true
Attached patch 1430421.patch β€” β€” Splinter Review
Sigh, looks like the author uses a different e-mail address for HG. This shows that I needed three attempts to get it right. So for the time being I suggest not to use tools which aren't fully integrated.
Attachment #8942486 - Attachment is obsolete: true
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/1cd741631051
Add .arcconfig to comm-central. r=tomprince
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 59.0
I'm sure with a little initial effort you'll find a quick way to do it, it is really not that complicated. As the author, I have updated my phabricator email address, so that part should be right next time.

As for the diff, setting up arcanist was fairly easy so there is that. Then you can also hg qimport https://phabricator.services.mozilla.com/D386?download=true (where the URL is copy link location from the raw diff).
See Also: → 1460372
You need to log in before you can comment on or make changes to this bug.