Closed Bug 1430425 Opened 2 years ago Closed 2 years ago

VideoStreamFactory constructor should pass codec name by reference

Categories

(Core :: Audio/Video, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: jeanluc.bonnafoux, Assigned: jeanluc.bonnafoux)

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20180103231032

Steps to reproduce:

static code analysis (ccpcheck v1.81) points out that constructor of VideoStreamFactory class (media-conduit/VideoConduit.h) should used a passed by reference codec name instead of a passed by value. 


Actual results:

Current code is fine but may involve unnecessary string copy.


Expected results:

codec name should be passed by const reference.
Comment on attachment 8942515 [details]
Bug 1430425 - VideoStreamFactory constructor should pass codec name by reference

https://reviewboard.mozilla.org/r/212770/#review218536

lgtm
Attachment #8942515 - Flags: review?(dminor) → review+
Assignee: nobody → jeanluc.bonnafoux
Pushed by paul@paul.cx:
https://hg.mozilla.org/integration/autoland/rev/7438fea5bc44
VideoStreamFactory constructor should pass codec name by reference r=dminor
Rank: 29
Priority: -- → P3
Status: UNCONFIRMED → NEW
Ever confirmed: true
https://hg.mozilla.org/mozilla-central/rev/7438fea5bc44
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.