143045 - Bug groups text is unclear

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Joe Robins]

When entering or changing a bug, if there are any bug groups that bug can belong 
to, users see the text "Only users in the selected groups can view this bug", 
and then a list of groups with checkboxes.  It is unclear whether this is 
supposed to mean "Only users in _all_ of the selected groups can view this bug" 
or "Only users in _any_ of the selected groups can view this bug".

We should change that text to read "Only users in all of the selected groups can 
view this bug", to clear up any confusion.

I will attach a patch momentarily.

Comment 1

[Joe Robins]

Attachment: Clarify the text on bug group selection

This patch changes the text in the templates.  I don't actually have a working
dev instance at the moment, so I can't verify this myself, but since it's just
a simple text change to the templates, I don't anticipate any problems.

Comment 2

[David D. Kilzer (ddk)]

While we're at it, I would change "can" to "may" within the 
phrase in question.  :^)

Comment 3

[Joe Robins]

I wouldn't change "can" to "may".  In this case, you literally can not view the 
bug if you are not in the appropriate groups, so I think the word "can" is more 
appropriate.

Comment 4

[David D. Kilzer (ddk)]

Good point.  How about changing "can view" to "are able to view"?
My original intent was to get rid of the word "can".

Comment 5

[Joe Robins]

What's wrong with "can"?

Comment 6

[Gervase Markham [:gerv]]

Comment on attachment 82814 [details] [diff] [review]
Clarify the text on bug group selection

> I wouldn't change "can" to "may".  In this case, you literally can not view the 
> bug if you are not in the appropriate groups, so I think the word "can" is more 
> appropriate.

I don't agree. :-) "May" implies it's optional for them to view this bug -
which is true; no-one's forcing them to view it :-) But on the other hand, I
don't see what people have against "can" either.

Both are fine; let's check in the current patch, which is fine, and move on.

2xr=gerv.

Gerv

Comment 7

[David D. Kilzer (ddk)]

In grade school, I was taught that "able" or "may" should be used
in place of "can" whenever possible, due to its ambiguity.

Also, the word "can" may(!) be ambiguous when translating English
to other languages.

Just my $0.02.  I'm not going to open another bug to audit the
use of "can" throughout the text output by Bugzilla, though. :^)

Comment 8

[Dave Miller [:justdave]]

reassign to patch author.

Joe doesn't have cvs access, who wants to check it in?

Comment 9

[Gervase Markham [:gerv]]

Fixed.

Checking in template/en/default/bug/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/edit.html.tmpl,v  <--
 edit.html.tmpl
new revision: 1.7; previous revision: 1.6
done
Checking in template/en/default/bug/create/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/create/create.html.tmpl,v
 <--  create.html.tmpl
new revision: 1.6; previous revision: 1.5
done

Gerv

Comment 10

[Thomas Thurman]

*** Bug 127645 has been marked as a duplicate of this bug. ***

Comment 11

[Marc Schumann [:Wurblzap]]

*** Bug 127645 has been marked as a duplicate of this bug. ***