Closed Bug 1430462 Opened 3 years ago Closed 3 years ago

Remove the toolbar-primary class

Categories

(Thunderbird :: Toolbars and Tabs, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 59.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file)

The toolbar-primary class is now only used for the tabs-toolbar. We should remove it and set the rule directly to the tabs-toolbar.
Removed all occurrences in mail: https://dxr.mozilla.org/comm-central/search?q=toolbar-primary+-path%3Aobj-x86
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8942500 - Flags: review?(jorgk)
Comment on attachment 8942500 [details] [diff] [review]
toolbar-primary.patch

I tried a few windows and they still work. Thanks for the clean-up.
editor/ui/composer/content/editor.xul is for the SM HTML editor, right?
Attachment #8942500 - Flags: review?(jorgk) → review+
(In reply to Jorg K (GMT+1) from comment #2)
> Comment on attachment 8942500 [details] [diff] [review]
> toolbar-primary.patch
> 
> I tried a few windows and they still work. Thanks for the clean-up.
> editor/ui/composer/content/editor.xul is for the SM HTML editor, right?

I would say yes. If we use it, I don't have seen this toolbar.
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/fcae4e561427
Remove the toolbar-primary class. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 59.0
You need to log in before you can comment on or make changes to this bug.