Closed Bug 1430490 Opened 2 years ago Closed 2 years ago

Remove unused -moz-border-*-colors in chat.css

Categories

(Thunderbird :: Instant Messaging, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 59.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file)

m-c is on removing support for -moz-border-*-colors. Chat has some occurrences we can remove.
Button needs no more the -moz-border-*-colors resets. The #noConvScreen is a NOP as the border is removed some lines later.

The other occurrences in windows/chat.css will be removed in bug 1420619.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8942530 - Flags: review?(florian)
Comment on attachment 8942530 [details] [diff] [review]
chat-colors.patch

Seems reasonable; I haven't tested the patch locally myself.
Attachment #8942530 - Flags: review?(florian) → review+
Thanks!
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/44f05d685ecb
Remove unused -moz-border-*-colors in chat.css. r=florian
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 59.0
(In reply to Richard Marti (:Paenglab) from comment #1)
> The #noConvScreen is a NOP as the border is removed some lines later.
Just out of interest: Where does that happen?
At the second hunk in mail/themes/windows/mail/chat.css.
Oh, I'm not a CSS expert. So the first hunk sets the border and the second removes it. Removing both hunks equally gives no border. I see. Thanks.
You need to log in before you can comment on or make changes to this bug.