Closed Bug 1430506 Opened 2 years ago Closed 2 years ago

Install pulseaudio 2.0 on Centos build images

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox59 fixed)

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

No description provided.
Comment on attachment 8942546 [details]
Bug 1430506 - Install pulseaudio 2.0 on CentOS build images.

https://reviewboard.mozilla.org/r/212788/#review218602

lgtm.  Consider commenting that the new `yum install` line is for PA.
Attachment #8942546 - Flags: review+
Attachment #8942546 - Flags: review?(core-build-config-reviews)
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/e3cd1efb911c
Install pulseaudio 2.0 on CentOS build images. r=nalexander
https://hg.mozilla.org/mozilla-central/rev/e3cd1efb911c
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Do you think this is too risky to land during the soft freeze? If so, it should be backed out.

I just want to make sure we have an answer to this question on file...
Flags: needinfo?(mh+mozilla)
I think it's low risk. However, I think it's risky enough that I don't want to land bug 1399679 before this change has made it through a cycle, and it's better if we can do that now with 59, and land bug 1399679 for 60. If we do see problems from this on 59, it's easier to backout just this.
Flags: needinfo?(mh+mozilla)
I agree with the assessment that bug 1399679 is much riskier and we should land as many of the "minor" changes as possible in a separate cycle to flush out their impact. This bug included.
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.