1430516 - Cannot select cell by [Ctrl] + mouse left click after landing bug 1425440

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Makoto Kato [:m_kato]]

This issue seems to be regression by bug 1425440.

- Step
1. Open data:text/html,<table border=1><tr><td>abc</td><td>def</td>
2. [Ctrl] + mouse left click "abc" cell in table

- Result
"abc" string is selected.  (abc's background is blue)

- Expected Result
Cell of "abc" is selected.  (table cell's border is blue).

Comment 1

[Makoto Kato [:m_kato]]

:baku, this issue seems to be regression by bug 1425440 according to mozgression.  Before landing it, [Ctrl] + mouse click selects table cell, not string into cell.  But after landing it, it selects string into cell instead.   Is this expected change?

Comment 2

[Makoto Kato [:m_kato]]

[Tracking Requested - why for this release]:
This is regression by bug 1425440

Comment 3

[Andrea Marchesini [:baku]]

Attachment: selection.patch

Before it was:

if ((endOffset - startOffset) != 1)

now it must be:

if (!child || child->GetNextSibling() != range->GetChildAtEndOffset()) {

but it was:

if (!child || child != range->GetChildAtEndOffset()) {

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f4d2bd7f41da
Fixing a regression when a table cell is selected, r=catalinb

Comment 5

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/f4d2bd7f41da