Open Bug 1430596 Opened 7 years ago Updated 2 years ago

[meta] Combine / de-duplicate Mozilla-Central & Devtools ESLint configurations

Categories

(DevTools :: General, enhancement, P3)

Product:
DevTools
Component:
General
Type:
enhancement

Tracking

(Not tracked)

People

(Reporter: standard8, Unassigned)

References

Details

(Keywords: meta)

User Story

- (done) Remove duplicate rules from devtools/.eslintrc.js that are duplicates of the main m-c configuration (where they are the same).
- (done) Separate eslint-plugin-mozilla recommended configuration into two: one for functional rules, one for stylistic rules (stylistic rules may be replaced by prettier at some stage in the future).
- (no longer applicable) Propose/extend devtools.html repositories with eslint-plugin-mozilla configuration if they get imported into gecko.
- Resolve differences between m-c configuration and devtools, where they are different, either enable for devtools, or discuss differences & determine way forward.
Currently devtools/ and the rest of mozilla-central have two fairly different configurations for ESLint. devtools/ references a lot more rules, and has defaults for some, or different items for others.

As per the proposal in https://github.com/devtools-html/rfcs/issues/30 we should work to unify these to make it simpler for gecko developers and more consistent across the board.

See the user story for specifics for the outline. I'll make these into separate bugs over the next few days.
Depends on: 1430615
Keywords: meta
Priority: -- → P3
Depends on: 1436303
Depends on: 1438489
Product: Firefox → DevTools

Mark, I think we can close this meta bug, correct?

Honza

Flags: needinfo?(standard8)

Not yet - whilst we've done the first couple of stages, we haven't harmonised the two configurations which I'd still like to do - or at least work towards as much as possible. I've updated the user story to clarify.

I had forgotten about this bug, so thanks for reminding me.

User Story: (updated)
Flags: needinfo?(standard8)
Depends on: 1782819
Depends on: 1330099
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.