Closed Bug 1430619 Opened 2 years ago Closed 2 years ago

Remove nsIContentViewerContainer

Categories

(Core :: DOM: Navigation, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: jwatt, Assigned: jwatt)

Details

Attachments

(3 files)

nsIContentViewerContainer provides only two things:

 1) an embed(...) method, which is only called by nsIDocShell, which
    is the class that implements nsIContentViewerContainer!

 2) a setIsPrinting(...) method, which in only called in one place by
    nsDocumentViewer::SetIsPrintingInDocShell.

So this interface just obfuscates the code a bit while [no longer] doing anything useful. We should just remove #1 from the interface and move #2 to nsIDocShell.
Priority: -- → P2
Bah. MozReview failed to tell me that my requested reviewer wasn't actually recognized...
Attachment #8942682 - Flags: review?(freesamael) → review?(bugs)
Attachment #8942683 - Flags: review?(freesamael) → review?(bugs)
Attachment #8942684 - Flags: review?(freesamael) → review?(bugs)
Comment on attachment 8942682 [details]
Bug 1430619 part 1 - Make nsIContentViewerContainer::embed non-IDL.

https://reviewboard.mozilla.org/r/212938/#review219896
Attachment #8942682 - Flags: review?(bugs) → review+
Comment on attachment 8942683 [details]
Bug 1430619 part 2 - Move nsIContentViewerContainer::setIsPrinting to nsIDocShell.

https://reviewboard.mozilla.org/r/212940/#review219898
Attachment #8942683 - Flags: review?(bugs) → review+
Comment on attachment 8942684 [details]
Bug 1430619 part 3 - Remove nsIContentViewerContainer.

https://reviewboard.mozilla.org/r/212942/#review219900
Attachment #8942684 - Flags: review?(bugs) → review+
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c01f4a01acdb
part 1 - Make nsIContentViewerContainer::embed non-IDL. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/34fa3317f8d1
part 2 - Move nsIContentViewerContainer::setIsPrinting to nsIDocShell. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/4cfac8e9af0b
part 3 - Remove nsIContentViewerContainer. r=smaug
You need to log in before you can comment on or make changes to this bug.