Closed
Bug 1430619
Opened 6 years ago
Closed 6 years ago
Remove nsIContentViewerContainer
Categories
(Core :: DOM: Navigation, enhancement, P2)
Core
DOM: Navigation
Tracking
()
RESOLVED
FIXED
mozilla59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: jwatt, Assigned: jwatt)
Details
Attachments
(3 files)
nsIContentViewerContainer provides only two things: 1) an embed(...) method, which is only called by nsIDocShell, which is the class that implements nsIContentViewerContainer! 2) a setIsPrinting(...) method, which in only called in one place by nsDocumentViewer::SetIsPrintingInDocShell. So this interface just obfuscates the code a bit while [no longer] doing anything useful. We should just remove #1 from the interface and move #2 to nsIDocShell.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Updated•6 years ago
|
Priority: -- → P2
Assignee | ||
Comment 4•6 years ago
|
||
Bah. MozReview failed to tell me that my requested reviewer wasn't actually recognized...
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•6 years ago
|
Attachment #8942682 -
Flags: review?(freesamael) → review?(bugs)
Attachment #8942683 -
Flags: review?(freesamael) → review?(bugs)
Attachment #8942684 -
Flags: review?(freesamael) → review?(bugs)
Comment 8•6 years ago
|
||
mozreview-review |
Comment on attachment 8942682 [details] Bug 1430619 part 1 - Make nsIContentViewerContainer::embed non-IDL. https://reviewboard.mozilla.org/r/212938/#review219896
Attachment #8942682 -
Flags: review?(bugs) → review+
Comment 9•6 years ago
|
||
mozreview-review |
Comment on attachment 8942683 [details] Bug 1430619 part 2 - Move nsIContentViewerContainer::setIsPrinting to nsIDocShell. https://reviewboard.mozilla.org/r/212940/#review219898
Attachment #8942683 -
Flags: review?(bugs) → review+
Comment 10•6 years ago
|
||
mozreview-review |
Comment on attachment 8942684 [details] Bug 1430619 part 3 - Remove nsIContentViewerContainer. https://reviewboard.mozilla.org/r/212942/#review219900
Attachment #8942684 -
Flags: review?(bugs) → review+
Comment 11•6 years ago
|
||
Pushed by jwatt@jwatt.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/c01f4a01acdb part 1 - Make nsIContentViewerContainer::embed non-IDL. r=smaug https://hg.mozilla.org/integration/mozilla-inbound/rev/34fa3317f8d1 part 2 - Move nsIContentViewerContainer::setIsPrinting to nsIDocShell. r=smaug https://hg.mozilla.org/integration/mozilla-inbound/rev/4cfac8e9af0b part 3 - Remove nsIContentViewerContainer. r=smaug
Comment 12•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c01f4a01acdb https://hg.mozilla.org/mozilla-central/rev/34fa3317f8d1 https://hg.mozilla.org/mozilla-central/rev/4cfac8e9af0b
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•