1430682 - Remove mDocViewerPrint null check in nsPagePrintTimer

Status: RESOLVED FIXED

(Core :: Printing: Setup, enhancement)

Description

[Jonathan Watt [:jwatt]]

In nsPagePrintTimer we set mDocViewerPrint in the ctor and never change it/null it out. We've been dereferencing mDocViewerPrint without a null check in nsPagePrintTimer's ctor for some time (and recently started dereferencing it in the dtor as of bug 1426087 too). So we know this null check is useless and just confusing.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Jonathan Watt [:jwatt]]

(In reply to Jonathan Watt [:jwatt] (needinfo? me) from comment #0)
> We've been dereferencing mDocViewerPrint without a null
> check in nsPagePrintTimer's ctor for some time.

By which I mean in excess of five years.

Comment 3

[Masatoshi Kimura [:emk]]

How about making mDocViewerPrint NotNull?

Comment 4

[Bob Owen (:bobowen)]

Comment on attachment 8942764 [details] [diff] [review]
patch

Review of attachment 8942764 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Masatoshi Kimura [:emk] from comment #3)
> How about making mDocViewerPrint NotNull?

Sounds like a good plan, I suppose it could be |const NotNull|.

Comment 5

[Jonathan Watt [:jwatt]]

(In reply to Masatoshi Kimura [:emk] from comment #3)
> How about making mDocViewerPrint NotNull?

Good suggestion (although I'll actually use OwningNotNull, and const as suggested by Bob).

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/76ce0d94b9b7
Use OwningNonNull for nsPagePrintTimer::mDocViewerPrint and remove null checks. r=bobowen

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/76ce0d94b9b7