1430694 - Crash in [@ mozilla::wr::NewRenderer::Run ]

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect, P1)

Description

[Darkspirit]

I hoped that bug 1377321 could "fix" bug 1406230.
But I think that bug 1406230 has morphed into this one, so I wouldn't call this a regression.

This would be just a nice to have. I just wanted to report this new crash signature.

1. set gfx.webrender.all;true, set extensions.webextensions.remote;true, create layers.gpu-process.enabled;true, restart
2. install https://addons.mozilla.org/firefox/addon/ipvfoo-pmarks/
3. visit https://bugzilla.mozilla.org/
4. maybe press F5 if you see a "?" instead of a red "4" in your locationbar
5. click on the red "4"
6. visit about:crashes

bp-a969ea67-b5f4-4738-be51-0b75f0180116
bp-341ca957-2bdb-481e-bcd0-f05cd0180116
----
bp-a969ea67-b5f4-4738-be51-0b75f0180116
bp-341ca957-2bdb-481e-bcd0-f05cd0180116
bp-2ac3e03f-a6bb-4eab-9a74-4db070180116

Comment 1

[Darkspirit]

(#0) Error	Failed to create WebRenderBridgeChild.
(#1) Error	Failed to create CompositorBridgeChild
(#2) Error	Failed to create remote compositor
(#3) Error	GLFeature::frag_color_float failed support probe, disabling. (RENDERER: AMD Radeon (TM) RX 480 Graphics (AMD POLARIS10 / DRM 3.19.0 / 4.14.0-2-amd64, LLVM 5.0.0))
(#4) Error	GLFeature::frag_color_float failed support probe, disabling. (RENDERER: AMD Radeon (TM) RX 480 Graphics (AMD POLARIS10 / DRM 3.19.0 / 4.14.0-2-amd64, LLVM 5.0.0))
(#5) Error	Compositors might be mixed (5,2)
(#6) 	CP+[GFX1-]: Receive IPC close with reason=AbnormalShutdown
(#7) 	CP+[GFX1-]: Receive IPC close with reason=AbnormalShutdown
(#8) Error	Receive IPC close with reason=AbnormalShutdown
(#9) Error	Receive IPC close with reason=AbnormalShutdown
(#10) Error	Receive IPC close with reason=AbnormalShutdown
(#11) 	CP+[GFX1-]: Receive IPC close with reason=AbnormalShutdown
(#12) Error	GLFeature::frag_color_float failed support probe, disabling. (RENDERER: AMD Radeon (TM) RX 480 Graphics (AMD POLARIS10 / DRM 3.19.0 / 4.14.0-2-amd64, LLVM 5.0.0))
(#13) Error	GLFeature::frag_color_float failed support probe, disabling. (RENDERER: AMD Radeon (TM) RX 480 Graphics (AMD POLARIS10 / DRM 3.19.0 / 4.14.0-2-amd64, LLVM 5.0.0))
(#14) Error	GLFeature::frag_color_float failed support probe, disabling. (RENDERER: AMD Radeon (TM) RX 480 Graphics (AMD POLARIS10 / DRM 3.19.0 / 4.14.0-2-amd64, LLVM 5.0.0))

Comment 2

[Sotaro Ikeda [:sotaro]]

Sorry, it is a regression of Bug 1429997.

Comment 3

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Check if RenderCompositor is created

Comment 4

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=40bc6dd7daa0064479602ff14208e461ce92eb2a

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/12fb412037a6
Check if RenderCompositor is created r=nical

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/12fb412037a6

Comment 7

[Darkspirit]

Nightly 59 x64 20180117100129 de_DE 4e429d313fd2e0f9202271ee8f3fb798817ec3e7 @ Debian Testing (KDE, Radeon RX480)
fresh profile: STR from comment 0

Verified fixed. Thanks! Now I have the old behavior from bug 1406230 comment 3 back:

> Entscheidungsprotokoll
> GPU_PROCESS	available by user: Enabled via layers.gpu-process.enabled
> WEBRENDER	opt-in by default: WebRender is an opt-in feature
> 		available by user: Enabled by pref
> 		unavailable by runtime: WebRender initialization failed
> OMTP		disabled by default: Disabled by default
> 
> Fehlerprotokoll
> (#0) Error	Compositors might be mixed (5,2)
> (#1) 	GP+[GFX1-]: Failed GL context creation for WebRender: 0
> (#2) 	GP+[GFX1-]: [OPENGL] Failed to init compositor with reason: FEATURE_FAILURE_OPENGL_CREATE_CONTEXT
> (#3) 	GP+[GFX1-]: [OPENGL] Failed to init compositor with reason: FEATURE_FAILURE_OPENGL_CREATE_CONTEXT
> (#4) 	GP+[GFX1-]: [OPENGL] Failed to init compositor with reason: FEATURE_FAILURE_OPENGL_CREATE_CONTEXT