Closed Bug 1430728 Opened 2 years ago Closed 2 years ago

[Wayland] - position wl_subsurface when widget allocation changes

Categories

(Core :: Widget: Gtk, enhancement, P2)

All
Linux
enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: stransky, Assigned: stransky)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

When widget allocation changes (typically GtkWindow resize) we need to reposition wl_subsurface accordingly.
Comment on attachment 8942857 [details]
Bug 1430728 - [Wayland] - position wl_subsurface when attached GtkWidget allocation changes,

https://reviewboard.mozilla.org/r/213126/#review218820

::: widget/gtk/mozcontainer.cpp:432
(Diff revision 1)
> +
> +#if defined(MOZ_WAYLAND)
> +    if (container->subsurface) {
> +        gint x, y;
> +        gdk_window_get_position(gtk_widget_get_window(widget), &x, &y);
> +        wl_subsurface_set_position(container->subsurface, x, y);

Could you please add some comment why this is required for wayland?
Attachment #8942857 - Flags: review?(jhorak) → review+
Pushed by stransky@redhat.com:
https://hg.mozilla.org/integration/autoland/rev/1da66dc82732
[Wayland] - position wl_subsurface when attached GtkWidget allocation changes, r=jhorak
https://hg.mozilla.org/mozilla-central/rev/1da66dc82732
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.