1430728 - [Wayland] - position wl_subsurface when widget allocation changes

Status: RESOLVED FIXED

(Core :: Widget: Gtk, enhancement, P2)

Description

[Martin Stránský [:stransky] (ni? me)]

When widget allocation changes (typically GtkWindow resize) we need to reposition wl_subsurface accordingly.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1430728 - [Wayland] - position wl_subsurface when attached GtkWidget allocation changes,

Review commit: https://reviewboard.mozilla.org/r/213126/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/213126/

Comment 2

[Jan Horak [:jhorak]]

Comment on attachment 8942857 [details]
Bug 1430728 - [Wayland] - position wl_subsurface when attached GtkWidget allocation changes,

https://reviewboard.mozilla.org/r/213126/#review218820

::: widget/gtk/mozcontainer.cpp:432
(Diff revision 1)
> +
> +#if defined(MOZ_WAYLAND)
> +    if (container->subsurface) {
> +        gint x, y;
> +        gdk_window_get_position(gtk_widget_get_window(widget), &x, &y);
> +        wl_subsurface_set_position(container->subsurface, x, y);

Could you please add some comment why this is required for wayland?

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 8942857 [details]
Bug 1430728 - [Wayland] - position wl_subsurface when attached GtkWidget allocation changes,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/213126/diff/1-2/

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 8942857 [details]
Bug 1430728 - [Wayland] - position wl_subsurface when attached GtkWidget allocation changes,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/213126/diff/2-3/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1da66dc82732
[Wayland] - position wl_subsurface when attached GtkWidget allocation changes, r=jhorak

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/1da66dc82732