Closed
Bug 1430739
Opened 6 years ago
Closed 6 years ago
Remove the wizard-box class
Categories
(Toolkit :: Themes, enhancement, P5)
Toolkit
Themes
Tracking
()
RESOLVED
FIXED
mozilla59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: dao, Assigned: vikas_mahato, Mentored)
References
Details
(Keywords: good-first-bug, Whiteboard: [lang=css])
Attachments
(1 file)
wizard-box isn't used in mozilla-central. comm-central has uses in mailnews/import/content/importDialog.xul and suite/common/profile/profileSelection.xul and these documents should just define the class themselves if they still need it. For the purpose of this bug, let's just remove these rules: https://searchfox.org/mozilla-central/rev/41925c0b6c6d58578690121de439d2a8d3d690f3/toolkit/themes/windows/global/global.css#235-238 https://searchfox.org/mozilla-central/rev/41925c0b6c6d58578690121de439d2a8d3d690f3/toolkit/themes/linux/global/global.css#220-223 https://searchfox.org/mozilla-central/rev/41925c0b6c6d58578690121de439d2a8d3d690f3/toolkit/themes/osx/global/global.css#195-198
Reporter | ||
Updated•6 years ago
|
status-firefox59:
affected → ---
Priority: -- → P5
Assignee | ||
Comment 1•6 years ago
|
||
Hey! Can I work on this bug?
Reporter | ||
Comment 2•6 years ago
|
||
Sure. :) Do you have the source code? Have you built Firefox yet?
Assignee | ||
Comment 3•6 years ago
|
||
Yes! I have the source and it is currently building.
Comment hidden (mozreview-request) |
Reporter | ||
Comment 5•6 years ago
|
||
mozreview-review |
Comment on attachment 8943222 [details] Bug 1430739 - Remove the wizard-box class https://reviewboard.mozilla.org/r/213558/#review219294 Looks good, thanks!
Attachment #8943222 -
Flags: review+
Reporter | ||
Updated•6 years ago
|
Assignee: nobody → vikasmahato0
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/76d1a0fa9eb7 Remove the wizard-box class r=dao
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/76d1a0fa9eb7
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•