1430785 - Make mozInlineSpellChecker not derived from nsIEditActionListener

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

EditorBase::mInlineSpellChecker is always an instance of mozInlineSpellChecker since EditorBase::GetInlineSpellChecker() always creates it via CID.
https://searchfox.org/mozilla-central/rev/41925c0b6c6d58578690121de439d2a8d3d690f3/editor/libeditor/EditorBase.cpp#1347,1368

Additionally, looks like that mozInlineSpellChecker.h can be exposed. So, we can make EditorBase directly stores mozInlineSpellChecker and calls only necessary edit action listener methods directly.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0793fb2d04adc22a82605db1fb36710ee708438b

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=00aac8ad08bfae7a4c74810752aefec7a8fb95b4

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cba108cfe14fae055dcb982a80f6ec5a3d0bef17

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1430785 - Make mozInlineSpellChecker not derived from nsIEditActionListener

mozInlineSpellChecker listens to only DidSplitNode() and DidJoinNodes().
So, EditorBase should call them directly rather than treating it as an
nsIEditActionListener since its runtime cost becomes really cheaper.

Different from EditorSpellCheck, nobody creates instance of
nsIInlineSpellChecker.  So, we can now stop supporting createInstance() for it
in chrome JS and should do this since EditorBase cannot support multiple
mozInlineSpellChecker instances without nsIEditActionListener interface.
Therefore, this patch removes the entry from factory.

Review commit: https://reviewboard.mozilla.org/r/214242/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/214242/

Comment 5

[Makoto Kato [:m_kato]]

Comment on attachment 8943884 [details]
Bug 1430785 - Make mozInlineSpellChecker not derived from nsIEditActionListener

https://reviewboard.mozilla.org/r/214242/#review220102

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f0d1a3a8ecef
Make mozInlineSpellChecker not derived from nsIEditActionListener r=m_kato

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/f0d1a3a8ecef