Make mozInlineSpellChecker not derived from nsIEditActionListener

RESOLVED FIXED in Firefox 60

Status

()

Core
Editor
RESOLVED FIXED
a month ago
3 days ago

People

(Reporter: masayuki, Assigned: masayuki)

Tracking

(Blocks: 1 bug)

Trunk
mozilla60
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox59 wontfix, firefox60 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

EditorBase::mInlineSpellChecker is always an instance of mozInlineSpellChecker since EditorBase::GetInlineSpellChecker() always creates it via CID.
https://searchfox.org/mozilla-central/rev/41925c0b6c6d58578690121de439d2a8d3d690f3/editor/libeditor/EditorBase.cpp#1347,1368

Additionally, looks like that mozInlineSpellChecker.h can be exposed. So, we can make EditorBase directly stores mozInlineSpellChecker and calls only necessary edit action listener methods directly.
Comment hidden (mozreview-request)

Comment 5

a month ago
mozreview-review
Comment on attachment 8943884 [details]
Bug 1430785 - Make mozInlineSpellChecker not derived from nsIEditActionListener

https://reviewboard.mozilla.org/r/214242/#review220102
Attachment #8943884 - Flags: review?(m_kato) → review+

Comment 6

a month ago
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/f0d1a3a8ecef
Make mozInlineSpellChecker not derived from nsIEditActionListener r=m_kato

Comment 7

a month ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f0d1a3a8ecef
Status: ASSIGNED → RESOLVED
Last Resolved: a month ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
status-firefox59: affected → wontfix
Depends on: 1439435
You need to log in before you can comment on or make changes to this bug.