Closed Bug 1430829 Opened 2 years ago Closed 2 years ago

Update webrender to e9269c7e06e20363be0b2a2a1be98d292ff7acca

Categories

(Core :: Graphics: WebRender, enhancement, P3)

59 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: kats, Assigned: kats)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [gfx-noted])

Attachments

(4 files)

+++ This bug was initially created as a clone of Bug #1429806 +++

I'm filing this as a placeholder bug for the next webrender update. I may be running a cron script [1] that does try pushes with webrender update attempts, so that we can track build/test breakages introduced by webrender on a rolling basis. This bug will hold the try push links as well as dependencies filed for those breakages, so that we have a better idea going into the update of what needs fixing. I might abort the cron job because once things get too far out of sync it's hard to fully automate fixing all the breakages.

When we are ready to actually land the update, we can rename this bug and use it for the update, and then file a new bug for the next "future update".

[1] https://github.com/staktrace/moz-scripts/blob/master/try-latest-webrender.sh
servo/webrender#2305 because it added some #[cfg(feature = "capture")] things that cbindgen (via syn-0.11.11) can't parse. So my script aborted at the step to regenerate the FFI header.
The specific #[cfg] statements that it had trouble with were the ones at https://github.com/servo/webrender/blob/9cad76acef7c1da00ba4beb1e01e764eee8fe4d5/webrender/src/renderer.rs#L2301 and the one two lines down from it. If I comment those out it works.
This is unfortunate... but should be easy to work around. I'll provide a PR/diff later today.
Thanks. I've filed a bug against cbindgen [1] so hopefully we can fix it there and remove the workaround. For now I'm just going to skip the FFI header regeneration step since it looks like there's no changes in the FFI structs.

[1] https://github.com/eqrion/cbindgen/issues/116
Could you verify if https://github.com/servo/webrender/pull/2316 is sufficient?
Flags: needinfo?(bugmail)
Yup, it is, thanks!
Flags: needinfo?(bugmail)
Blocks: 1429614
Blocks: 1429793
No longer blocks: 1429614
Is this something you want to keep using, or can be fixed with small blood on Gecko side?
I can fix it on the Gecko side, I think. Building a patch now.
There was also an R4-opt unexpected pass. Not sure why it's opt-only but there you go.
The R4-opt thing came from m-c, it's not from a WR change.
Alias: wr-future-update
Assignee: nobody → bugmail
Summary: Future webrender update bug → Update webrender to e9269c7e06e20363be0b2a2a1be98d292ff7acca
Version: unspecified → 59 Branch
Comment on attachment 8944006 [details]
Bug 1430829 - Update webrender to commit e9269c7e06e20363be0b2a2a1be98d292ff7acca.

https://reviewboard.mozilla.org/r/214332/#review220040
Attachment #8944006 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8944007 [details]
Bug 1430829 - Update Cargo lockfiles and re-vendor rust dependencies.

https://reviewboard.mozilla.org/r/214334/#review220042
Attachment #8944007 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8944008 [details]
Bug 1430829 - Update for removal of ImageFormat::Invalid in WR PR 2317.

https://reviewboard.mozilla.org/r/214336/#review220044
Attachment #8944008 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8944009 [details]
Bug 1430829 - Reduce fuzz in reftest from WR PR 2308.

https://reviewboard.mozilla.org/r/214338/#review220046
Attachment #8944009 - Flags: review?(jmuizelaar) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d1a22efb9e43
Update webrender to commit e9269c7e06e20363be0b2a2a1be98d292ff7acca. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/ce7010ea6de7
Update Cargo lockfiles and re-vendor rust dependencies. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/6a281573abf4
Update for removal of ImageFormat::Invalid in WR PR 2317. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/6d9dc65ca0ed
Reduce fuzz in reftest from WR PR 2308. r=jrmuizel
Depends on: 1431955
Depends on: 1431963
You need to log in before you can comment on or make changes to this bug.