1430829 - Update webrender to e9269c7e06e20363be0b2a2a1be98d292ff7acca

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

+++ This bug was initially created as a clone of Bug #1429806 +++

I'm filing this as a placeholder bug for the next webrender update. I may be running a cron script [1] that does try pushes with webrender update attempts, so that we can track build/test breakages introduced by webrender on a rolling basis. This bug will hold the try push links as well as dependencies filed for those breakages, so that we have a better idea going into the update of what needs fixing. I might abort the cron job because once things get too far out of sync it's hard to fully automate fixing all the breakages.

When we are ready to actually land the update, we can rename this bug and use it for the update, and then file a new bug for the next "future update".

[1] https://github.com/staktrace/moz-scripts/blob/master/try-latest-webrender.sh

Comment 1

[Kartikaya Gupta (email:[e-mail])]

servo/webrender#2305 because it added some #[cfg(feature = "capture")] things that cbindgen (via syn-0.11.11) can't parse. So my script aborted at the step to regenerate the FFI header.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

The specific #[cfg] statements that it had trouble with were the ones at https://github.com/servo/webrender/blob/9cad76acef7c1da00ba4beb1e01e764eee8fe4d5/webrender/src/renderer.rs#L2301 and the one two lines down from it. If I comment those out it works.

Comment 3

[Dzmitry Malyshau [:kvark]]

This is unfortunate... but should be easy to work around. I'll provide a PR/diff later today.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Thanks. I've filed a bug against cbindgen [1] so hopefully we can fix it there and remove the workaround. For now I'm just going to skip the FFI header regeneration step since it looks like there's no changes in the FFI structs.

[1] https://github.com/eqrion/cbindgen/issues/116

Comment 5

[Dzmitry Malyshau [:kvark]]

Could you verify if https://github.com/servo/webrender/pull/2316 is sufficient?

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Yup, it is, thanks!

Comment 7

[Kartikaya Gupta (email:[e-mail])]

WR @ 9cad76acef7c1da00ba4beb1e01e764eee8fe4d5 (this is with the ffi regeneration step skipped)

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0c4cea5ad05fb531fa50a113b5fbd86c26b8ef7a
https://treeherder.mozilla.org/#/jobs?repo=try&revision=11cdc2ae3ab2d0db5fe681403ac0bcd3b271cc95

Looking green so far

Comment 8

[Kartikaya Gupta (email:[e-mail])]

WR @ 8811f69c4940b8d37b09aacf449f1b1932bf1e5e

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e7839088a9fb83f04c92216088ee4ab71537b4dd
https://treeherder.mozilla.org/#/jobs?repo=try&revision=258aa6fa9fa8a363847c2f8d7b4d1f3e347746ad

Green. The h2 failure is expected, it is already disabled on m-c

WR @ 2547f6fe91da018cd3374acd661effb5f8fbe022

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8915a19fda816b4a7e040c30fda26241dd0f96eb
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e8aade66d218aca0fc8df0fff78934382dd8a2ff

Green

Comment 9

[Kartikaya Gupta (email:[e-mail])]

WR @ c8babed1402ee71a208fcbea74a11b2c0a5e8843

https://treeherder.mozilla.org/#/jobs?repo=try&revision=63e1aed4d06dd71c179e15c41fd32ffeebbb6803
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9d5f908e779d218dcf97e442689682c162951094

Bustage, from servo/webrender#2317. We're still using ImageFormat::Invalid in gecko and it was removed in WR.

Comment 10

[Dzmitry Malyshau [:kvark]]

Is this something you want to keep using, or can be fixed with small blood on Gecko side?

Comment 11

[Kartikaya Gupta (email:[e-mail])]

I can fix it on the Gecko side, I think. Building a patch now.

Comment 12

[Kartikaya Gupta (email:[e-mail])]

WR @ 46bd3a07cd002401005d8387f98fe187cc3b8cdf with bustage fix

https://treeherder.mozilla.org/#/jobs?repo=try&revision=375987120b09b3a5b7e4f42192237c9a0afcf13b
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e9c89585872a27aeacac62d80cde8347bca1aa69

Green so far

Comment 13

[Kartikaya Gupta (email:[e-mail])]

WR @ 46bd3a07cd002401005d8387f98fe187cc3b8cdf

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d13fe8c4f00dbc5071624b7f035464162595371c
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ca157caf56cefcc7cd1fca035f28704ccf68db6f

Still green

Comment 14

[Kartikaya Gupta (email:[e-mail])]

WR @ 5fae1ac37d9c9adf45601cfad83b31a3d6bafd68

https://treeherder.mozilla.org/#/jobs?repo=try&revision=dad0ba506f8aa8065af431056303d50c5b40ff61
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1ab7ce5cac77aeee36f3a3436cda14064bbc936b

R3 unexpected pass, just some fuzzy numbers that need reducing, looks like. From servo/webrender#2308.

Comment 15

[Kartikaya Gupta (email:[e-mail])]

There was also an R4-opt unexpected pass. Not sure why it's opt-only but there you go.

Comment 16

[Kartikaya Gupta (email:[e-mail])]

Err the R4-opt unexpected pass only showed up at WR @ e9269c7e06e20363be0b2a2a1be98d292ff7acca:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e4e69355476318fbc918eb08a802e1d2cc27a7ed

https://treeherder.mozilla.org/#/jobs?repo=try&revision=750c40072847e3ac2f072042699fe4a2a48e25f3
https://treeherder.mozilla.org/#/jobs?repo=try&revision=572384df92dcfea6f51e71034513eb194499095e

Comment 17

[Kartikaya Gupta (email:[e-mail])]

The R4-opt thing came from m-c, it's not from a WR change.

Comment 18

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1430829 - Update webrender to commit e9269c7e06e20363be0b2a2a1be98d292ff7acca.

Review commit: https://reviewboard.mozilla.org/r/214332/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/214332/

Comment 19

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1430829 - Update Cargo lockfiles and re-vendor rust dependencies.

Review commit: https://reviewboard.mozilla.org/r/214334/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/214334/

Comment 20

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1430829 - Update for removal of ImageFormat::Invalid in WR PR 2317.

Review commit: https://reviewboard.mozilla.org/r/214336/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/214336/

Comment 21

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1430829 - Reduce fuzz in reftest from WR PR 2308.

Review commit: https://reviewboard.mozilla.org/r/214338/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/214338/

Comment 22

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8944006 [details]
Bug 1430829 - Update webrender to commit e9269c7e06e20363be0b2a2a1be98d292ff7acca.

https://reviewboard.mozilla.org/r/214332/#review220040

Comment 23

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8944007 [details]
Bug 1430829 - Update Cargo lockfiles and re-vendor rust dependencies.

https://reviewboard.mozilla.org/r/214334/#review220042

Comment 24

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8944008 [details]
Bug 1430829 - Update for removal of ImageFormat::Invalid in WR PR 2317.

https://reviewboard.mozilla.org/r/214336/#review220044

Comment 25

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8944009 [details]
Bug 1430829 - Reduce fuzz in reftest from WR PR 2308.

https://reviewboard.mozilla.org/r/214338/#review220046

Comment 26

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d1a22efb9e43
Update webrender to commit e9269c7e06e20363be0b2a2a1be98d292ff7acca. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/ce7010ea6de7
Update Cargo lockfiles and re-vendor rust dependencies. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/6a281573abf4
Update for removal of ImageFormat::Invalid in WR PR 2317. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/6d9dc65ca0ed
Reduce fuzz in reftest from WR PR 2308. r=jrmuizel

Comment 27

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/d1a22efb9e43
https://hg.mozilla.org/mozilla-central/rev/ce7010ea6de7
https://hg.mozilla.org/mozilla-central/rev/6a281573abf4
https://hg.mozilla.org/mozilla-central/rev/6d9dc65ca0ed