Update Debugger Frontend v9.1

RESOLVED FIXED in Firefox 59

Status

enhancement
P3
normal
RESOLVED FIXED
2 years ago
Last year

People

(Reporter: jlast, Assigned: jlast)

Tracking

unspecified
Firefox 59
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox59 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Fixes some small bugs that will be helpful for Firefox 59

https://github.com/devtools-html/debugger.html/compare/release-9...release-9-1?expand=1

+  [SourceTree] show loading sources (#5094) 
+  Icons are made Brighter (#5038) 
+  Make loading source maps safer (#5095) 
+  Speed up generated source parsing (#5101) 
+  Disable map scopes (#5111)
Assignee: nobody → jlaster
Priority: -- → P3
Posted patch 9-1.patch (obsolete) — Splinter Review
Attachment #8943243 - Flags: review?(jdescottes)
Comment on attachment 8943243 [details] [diff] [review]
9-1.patch

Review of attachment 8943243 [details] [diff] [review]:
-----------------------------------------------------------------

Some issues here before we can land this.

::: devtools/client/debugger/new/README.mozilla
@@ +1,4 @@
>  This is the debugger.html project output.
>  See https://github.com/devtools-html/debugger.html
>  
> +Taken from upstream commit: 1f9be6fda2d0722e906ae22fad156b282b0a0d25

Readme incorrect

::: devtools/client/debugger/new/test/mochitest/browser_dbg-minified.js
@@ +15,5 @@
>    return findElement(dbg, "scopeValue", index).innerText;
>  }
>  
>  add_task(async function() {
> +  Services.prefs.setBoolPref("devtools.debugger.features.map-scopes", true);

You should use await pushPref("devtools.debugger.features.map-scopes", true), otherwise this pref can leak to other tests.

::: devtools/client/debugger/new/test/mochitest/browser_dbg-sourcemaps3.js
@@ +24,5 @@
>  // This source map does not have source contents, so it's fetched separately
>  add_task(async function() {
>    // NOTE: the CORS call makes the test run times inconsistent
>    requestLongerTimeout(2);
> +  Services.prefs.setBoolPref("devtools.debugger.features.map-scopes", true);

ditto
Attachment #8943243 - Flags: review?(jdescottes)
Posted patch 9-1-2.patch (obsolete) — Splinter Review
This was missing a commit

https://treeherder.mozilla.org/#/jobs?repo=try&revision=06cdec11b06073218e07e9fbad368fcf875de79f
Attachment #8943243 - Attachment is obsolete: true
Attachment #8943289 - Flags: review?(jdescottes)
Comment on attachment 8943289 [details] [diff] [review]
9-1-2.patch

Review of attachment 8943289 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, will amend with readme fix + test fixes (and will port back to debugger)

::: devtools/client/debugger/new/README.mozilla
@@ +2,5 @@
>  See https://github.com/devtools-html/debugger.html
>  
> +Version 9.1
> +commit: https://github.com/devtools-html/debugger.html/commit/fe8208137f312bcab54d599468b37987b93bbf8c
> +comparison: https://github.com/devtools-html/debugger.html/compare/release-9...release-9.1

9.1 -> 9-1 (even though I'd prefer the branch to be named release-9.1)
Attachment #8943289 - Flags: review?(jdescottes) → review+
Amended to fix issues mentioned in review.
Attachment #8943289 - Attachment is obsolete: true
Attachment #8943320 - Flags: review+
oh ha - i could release a new branch w/ 9.1 instead of 9-1...
(In reply to Jason Laster [:jlast] from comment #8)
> oh ha - i could release a new branch w/ 9.1 instead of 9-1...

Let's leave it like this now that the README is in sync.
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4f42c8b2e10c
Update Debugger Frontend v9.1. r=jdescottes
https://hg.mozilla.org/mozilla-central/rev/4f42c8b2e10c
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.