1430872 - Stop wrapping the whole browser window in a deck (remove tab-view-deck and browser-panel)

Status: RESOLVED FIXED

(Firefox :: General, enhancement, P3)

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1430872 - remove tab-view-deck and browser-panel.

Review commit: https://reviewboard.mozilla.org/r/213280/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/213280/

Comment 2

[:Gijs (he/him)]

Comment on attachment 8943007 [details]
Bug 1430872 - remove tab-view-deck and browser-panel.

https://reviewboard.mozilla.org/r/213280/#review219248

::: browser/themes/windows/compacttheme.css:128
(Diff revision 1)
>  
> -  /* Use default window colors when in non-maximized mode */
> +  /* Use default window colors */
> -  #tabbrowser-tabs,
>    #TabsToolbar,
> -  #browser-panel,
> -  #titlebar-content {
> +  #navigator-toolbox {
> +    background-color: transparent;

For the benefit of future archaeology, can you explain why you removed `#titlebar-content` from this selector?

Comment 3

[Dão Gottwald [:dao]]

(In reply to :Gijs from comment #2)
> ::: browser/themes/windows/compacttheme.css:128
> (Diff revision 1)
> >  
> > -  /* Use default window colors when in non-maximized mode */
> > +  /* Use default window colors */
> > -  #tabbrowser-tabs,
> >    #TabsToolbar,
> > -  #browser-panel,
> > -  #titlebar-content {
> > +  #navigator-toolbox {
> > +    background-color: transparent;
> 
> For the benefit of future archaeology, can you explain why you removed
> `#titlebar-content` from this selector?

#titlebar-content doesn't get a background in the first place on Windows.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/80e57c896fd7
remove tab-view-deck and browser-panel. r=Gijs

Comment 5

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/80e57c896fd7

Comment 6

[init]

Is there any way to move toolbars to the window bottom after this change? The following userChrome.css solution does not work anymore:

#browser-panel {
  -moz-box-direction: reverse;
}

Replacing browser-panel with navigator-toolbox does not give me the correct result.

Comment 7

[Dão Gottwald [:dao]]

(In reply to init from comment #6)
> Is there any way to move toolbars to the window bottom after this change?

Using -moz-box-ordinal-group, yes.

Comment 8

[init]

Thanks. I was able to restore my preferred layout with:

#navigator-toolbox {
  -moz-box-ordinal-group: 2;
}