1430873 - crash reporter breakpad, incorrect printf option

Status: UNCONFIRMED

(Toolkit :: Crash Reporting, defect)

Description

[jbonnafo]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20180103231032

Steps to reproduce:

Static code analysis (cppcheck 1.81) points out usage of incorrect printf options.
most common case is use of %d but printing an unsigned int.


Actual results:

The appropriate option (Eg: %u for unsigned int) should be used.
Using incorrect printf option for unsigned int may cause printing incorrect values for large integers.


Expected results:

Code should use correct printf options.

Comment 1

[jbonnafo]

Attachment: Bug 1430873 - crash reporter breakpad, incorrect printf option

Review commit: https://reviewboard.mozilla.org/r/213284/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/213284/

Comment 2

[Gabriele Svelto [:gsvelto]]

This error happens within breakpad's code. You'll have to fix it upstream before we can pull it in. We generally don't apply patches to external code we ship unless they've been upstreamed first. You can find the breakpad project here:

https://chromium.googlesource.com/breakpad/breakpad/

Comment 3

[Gabriele Svelto [:gsvelto]]

Comment on attachment 8943015 [details]
Bug 1430873 - crash reporter breakpad, incorrect printf option

https://reviewboard.mozilla.org/r/213284/#review219020

Comment 4

[jbonnafo]

Thanks for you review, should i keep this bug opened?

Comment 5

[Gabriele Svelto [:gsvelto]]

Yes, we can close it once we fixed it upstream and sync'd our copy to take the fix.