Closed Bug 143088 Opened 23 years ago Closed 23 years ago

Freeze nsIDOMWindow

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.0

People

(Reporter: jud, Assigned: jst)

Details

(Keywords: topembed+, Whiteboard: [FIXED ON TRUNK])

Attachments

(1 file, 2 obsolete files)

Incorporate vidur's feedback...
6.41 KB, patch
fabian
: review+
asa
: superreview+
asa
: approval+
Details | Diff | Splinter Review
nsIDOMWindow is currently leveraged by various other frozen interfaces, and subsequently needs freezing itself.
Keywords: topembed+
Status: NEW → ASSIGNED
Component: DOM Other → DOM Level 0
OS: Windows 2000 → All
Hardware: PC → All
Target Milestone: --- → mozilla1.0
Comment on attachment 82841 [details] [diff] [review] Freeze nsIDOMWindow and nsIDOMBarProp sr=vidur once nsIDOMWindowCollection is also frozen.
Attachment #82841 - Flags: superreview+
Attachment #82841 - Attachment is obsolete: true
Comment on attachment 82844 [details] [diff] [review] Freeze nsIDOMWindowCollection too... sr=vidur. Things I would add to comments: 1) For parent property of nsIDOMWindow: Null if this is the root of the window hieararchy. Note that the parent property does not span across content and chrome boundaries. 2) For the top property of nsIDOMWindow: Accessor for the *root* of this window hierarchy. Note that the root is relative only to ancestors of the same type - chrome or content. 3) For the textZoom property on nsIDOMWindow: The first sentence should read "Set/Get the document scale factor as a multiplier on the default size". 4) For scrollX and scrollY properties of nsIDOMWindow: Specify the units (pixels?) of the values. 5) For item() and namedItem() methods of nsIDOMWindowCollection: What happens when the index is out of range or the named window doesn't exist? Do we return an error code or just null for the result nsIDOMWindow?
Attachment #82844 - Flags: superreview+
Attachment #82844 - Attachment is obsolete: true
Comment on attachment 82848 [details] [diff] [review] Incorporate vidur's feedback... r=fabian
Attachment #82848 - Flags: review+
Whiteboard: [FIXED ON TRUNK]
Comment on attachment 82848 [details] [diff] [review] Incorporate vidur's feedback... a=asa (on behalf of drivers) for checkin to the 1.0 branch
Attachment #82848 - Flags: superreview+
Attachment #82848 - Flags: approval+
Fixed on the mozilla1.0 branch too.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Keywords: fixed1.0.0
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: