1430881 - AWFY - awfy-cmp-win hang caused by Edge running octane

Status: RESOLVED FIXED

(Testing Graveyard :: AWFY, enhancement)

Description

[Bob Clary [:bc] (inactive)]

Attachment: AWFY.log

We were able to get logs when awfy-cmp-win hung. It appears to be Edge/octane but the hang occurred fairly quickly after the run started. Attaching the log for your viewing pleasure.

Ben: What is our next step here?

Comment 1

[Benjamin Bouvier [:bbouvier] (inactive)]

Hard to say.

It seems that AWFY can't even find Edge on the machine; it might be useful to check if ./edge.py works (it just produces an info.json file that's then being used by execute.py), and if ./execute.py manages to start Edge, on a cygwin / windows machine. Perhaps a path changed or something?

Just a word of caution here: if I remember correctly, logs are flushed after being written out, right? Just want to confirm there's no risk another message is showing up somewhere and we'd be missing it.

Comment 2

[Bob Clary [:bc] (inactive)]

There is always a possibility we miss a message but we flush the logging log handlers at the same time the stdout, stderr are flushed.

If Edge isn't running, then Firefox is causing the hang.

Comment 3

[Bob Clary [:bc] (inactive)]

Attachment: https://github.com/mozilla/arewefastyet/pull/191

fix name collision which prevents proper initialization of the submitter.

Comment 4

[Benjamin Bouvier [:bbouvier] (inactive)]

Comment on attachment 8943286 [details] [diff] [review]
https://github.com/mozilla/arewefastyet/pull/191

Review of attachment 8943286 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks

Comment 5

[Bob Clary [:bc] (inactive)]

The real problem or at least another was the improper call to super in PrintSubmitter.
https://github.com/mozilla/arewefastyet/commit/c932ede73f4d3abc8ab8d8fc372c89ce524a2c5b

Comment 6

[Bob Clary [:bc] (inactive)]

python execute.py --submitter print -b remote.sunspider -b remote.octane -b remote.kraken -b remote.massive -b local.assorteddom -b local.webaudio -b local.unity-webgl -b remote.jetstream -b remote.speedometer-misc -e ~/repos/edge/ -c default --submitter-mode "edge,default:edge_win10"

is running Edge fwiw.

Comment 7

[Bob Clary [:bc] (inactive)]

I ran Firefox and Chrome manually and did not experience a problem. I've restarted testing for the moment until the next hang at least.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:bc, could you have a look please?

Comment 9

[Bob Clary [:bc] (inactive)]

This was actually merged https://github.com/mozilla/arewefastyet/pull/191 so I'll mark it fixed though this framework is now decommissioned.