1430902 - Handle invalid schemas

Status: RESOLVED FIXED

(Taskcluster :: Services, enhancement)

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

Specifically, the issue is that we allow users to upload invalid triggerSchemas, and then validate them later, causing failures.  They should be validated on createHook/updateHook.

Alex, is it OK if I take this bug?

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

https://github.com/taskcluster/taskcluster-hooks/pull/76

Comment 3

[Alexandra Silva (:alexandra_)]

(In reply to Dustin J. Mitchell [:dustin] pronoun: he from comment #2)
> https://github.com/taskcluster/taskcluster-hooks/pull/76

I've pushed some changes and one doubt. I am not sure if context.payload can be used to validation.

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/taskcluster/taskcluster-hooks

https://github.com/taskcluster/taskcluster-hooks/commit/3c075bf2b8e06f02e2ebfdb43b17804420bcfca8
Merge pull request #76 from alexandrasp/schemaValidationErrors

handle invalid schemas - bug 1430902

Comment 5

[Dustin J. Mitchell [:dustin] (he/him)]

OK, that's landed, but the result is

---
Error executing operation

Invalid Schema
---

which isn't too helpful.  The AJV docs say that ajv.errors is set, so we can probably format that.

Comment 6

[Dustin J. Mitchell [:dustin] (he/him)]

I think this will make a good first bug from here.  The commit in comment 4 shows where this error is raised.  What remains to do is to add some code to extract the errors from ajv.errors and include them in the message.  You can find some examples of using ajv.errorsText in `src/v1.js` to help figure that out.

Comment 7

[[github robot]]

Commit pushed to master at https://github.com/taskcluster/taskcluster-hooks

https://github.com/taskcluster/taskcluster-hooks/commit/088fcce7a42f02bce1b19161ca1f20b814caf383
Merge pull request #110 from alexandrasp/extract-error-message-in-invalid-schema

Bug 1430902: Format a invalid error message

Comment 8

[Dustin J. Mitchell [:dustin] (he/him)]

Nice work!  And welcome back :)

Comment 9

[Alexandra Silva (:alexandra_)]

(In reply to Dustin J. Mitchell [:dustin] pronoun: he from comment #8)
> Nice work!  And welcome back :)

Thanks Dustin!! :) Happy to be back o/