Closed Bug 1430925 Opened 4 years ago Closed 4 years ago

requirejs timeout causes test timeout

Categories

(DevTools :: JSON Viewer, defect)

defect
Not set
normal

Tracking

(firefox59 fixed)

RESOLVED FIXED
Firefox 59
Tracking Status
firefox59 --- fixed

People

(Reporter: Oriol, Assigned: Oriol)

Details

Attachments

(1 file)

Lately the various dupes of bug 1424372 are filed with just a 'Test timed out' message, e.g. bug 1429095. Probably this was caused by bug 1417039. This makes them hard to distinguish from normal timeouts.

Previously it was better but the failed scripts could vary, so lots of different bugs were filed.

I think addJsonViewTab should detect requirejs failures, and then fail an assert and reject the returned promise so that the test can end.
Comment on attachment 8943253 [details]
Bug 1430925 - Avoid JSON Viewer test timeouts when RequireJS fails

https://reviewboard.mozilla.org/r/213576/#review219642

I see, looks reasonable.

R+

Is there any known reason for the error/timeout?

Thanks for working on this Oriol!

Honza
Attachment #8943253 - Flags: review?(odvarko) → review+
Summary: requirejs tiemout causes test timeout → requirejs timeout causes test timeout
(In reply to Jan Honza Odvarko [:Honza] from comment #2)
> Is there any known reason for the error/timeout?

No idea, 7 seconds should be more than enough to retrieve the local scripts, but it fails frequently.
Assignee: nobody → oriol-bugzilla
Status: NEW → ASSIGNED
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/57c4ffac0ccf
Avoid JSON Viewer test timeouts when RequireJS fails r=Honza
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/57c4ffac0ccf
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.