1430925 - requirejs timeout causes test timeout

Status: RESOLVED FIXED

(DevTools :: JSON Viewer, defect)

Description

[Oriol Brufau [:Oriol]]

Lately the various dupes of bug 1424372 are filed with just a 'Test timed out' message, e.g. bug 1429095. Probably this was caused by bug 1417039. This makes them hard to distinguish from normal timeouts.

Previously it was better but the failed scripts could vary, so lots of different bugs were filed.

I think addJsonViewTab should detect requirejs failures, and then fail an assert and reject the returned promise so that the test can end.

Comment 1

[Oriol Brufau [:Oriol]]

Attachment: Bug 1430925 - Avoid JSON Viewer test timeouts when RequireJS fails

Review commit: https://reviewboard.mozilla.org/r/213576/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/213576/

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8943253 [details]
Bug 1430925 - Avoid JSON Viewer test timeouts when RequireJS fails

https://reviewboard.mozilla.org/r/213576/#review219642

I see, looks reasonable.

R+

Is there any known reason for the error/timeout?

Thanks for working on this Oriol!

Honza

Comment 3

[Oriol Brufau [:Oriol]]

(In reply to Jan Honza Odvarko [:Honza] from comment #2)
> Is there any known reason for the error/timeout?

No idea, 7 seconds should be more than enough to retrieve the local scripts, but it fails frequently.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/57c4ffac0ccf
Avoid JSON Viewer test timeouts when RequireJS fails r=Honza

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/57c4ffac0ccf