Closed Bug 1430927 Opened 2 years ago Closed 2 years ago

Require Rust 1.24

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox60 fixed)

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: rillian, Assigned: rillian)

References

Details

Attachments

(1 file)

Per schedule, we expect to allow code requiring Rust 1.24 in m-c 2018 March 6. 

This bug is about bumping the minimum requirement enforced by configure and verified by the base-toolchain build tasks. It's also helpful to remind servo, webrender, etc. they can bump their testing revisions, e.g. in servo/geckolib-rust-toolchain.

https://wiki.mozilla.org/index.php?title=Rust_Update_Policy_for_Firefox
Depends on: 1430928
Blocks: 1433747
2018-03-06 is when mozilla-central and mozilla-beta stay in sync on 60 for 1 week before 59 is released. Would you still bump required Rust version? If not expect bug 1433747 to bite some downstream users (e.g., Gentoo, FreeBSD, maybe Arch). If yes adjust the wiki to document Firefox 60 would require Rust 1.24.
(In reply to Jan Beich from comment #1)
> 2018-03-06 is when mozilla-central and mozilla-beta stay in sync on 60 for 1
> week before 59 is released. Would you still bump required Rust version? If
> not expect bug 1433747 to bite some downstream users (e.g., Gentoo, FreeBSD,
> maybe Arch). If yes adjust the wiki to document Firefox 60 would require
> Rust 1.24.

Ralph, WDYT?  I think we want to move to Rust 1.24 for ESR 60, even if the release notes[1] don't have anything super-super-interesting.

[1] https://github.com/Aaronepower/rust/blob/master/RELEASES.md#version-1240-2018-02-15
Flags: needinfo?(giles)
Assuming there are no problems with 1.24 on official builds, I think we should require it for Firefox 60 in general. I sounds like that will avoid the issue for more people building downstream and the requirement can ride the train into 60 esr. Especially since release day has moved up a week, I think that will be the least disruptive.

We should make an effort to get this bug landed before the pre-beta branch point, so a few days early on March 4 or 6.
Flags: needinfo?(giles)
(In reply to Ralph Giles (:rillian) | needinfo me from comment #3)
> We should make an effort to get this bug landed before the pre-beta branch
> point, so a few days early on March 4 or 6.

Probably should just try to get it landed a full week early, just to make sure nothing goes wrong with tree closures or something.  Do you have cycles for the update to 1.24 and the requirement of 1.24?
Flags: needinfo?(giles)
Per IRC discussion, I've updated the release schedule ameliorate bug 1433747. Since the Firefox release has moved a week later since I wrote the update schedule we can start requiring Rust 1.24 on March 1. That gives us the expected two weeks transition time after the stable rust release and can ride the trains through the soft freeze to Firefox 60 beta, then release and ESR.

I've updated the page at https://wiki.mozilla.org/index.php?title=Rust_Update_Policy_for_Firefox
Flags: needinfo?(giles)
Rust 1.24 sets the default number of codegen units to 16 (with a jobserver so that actual parallelism does not exceed the number of hardware threads). https://github.com/rust-lang/rust/pull/46910

When updating we should consider removing our explicit `codegen-units = 4` config in the root Cargo.toml files. (Four made more sense when the jobserver did not exist yet.)
That's a good idea. bug 1436251 set `codegen-units=1` for opt builds, but we might as well let rustc do what it can for debug builds.
Attachment #8953198 - Flags: review?(core-build-config-reviews) → review+
https://hg.mozilla.org/mozilla-central/rev/4ff0b140243a
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Product: Core → Firefox Build System
No longer blocks: 1450078
You need to log in before you can comment on or make changes to this bug.