Closed
Bug 1430960
Opened 6 years ago
Closed 6 years ago
[km] Search engine setup for Firefox Mobile for Khmer
Categories
(Mozilla Localizations :: km / Khmer, enhancement)
Mozilla Localizations
km / Khmer
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: delphine, Assigned: delphine)
References
()
Details
(Keywords: productization)
Attachments
(1 file)
2.88 KB,
patch
|
flod
:
review+
|
Details | Diff | Splinter Review |
Since this was set up 3 years ago, I want to be sure all the files are still correct - and see if the community is still OK with the list that was set up (which was: "google", "yahoo", "bing", "amazondotcom", "twitter", "wikipedia-km") Thanks! (please find the usual message about search plugins that we send out below) ---- We want to ship Firefox Mobile with a good list of search engines for Khmer. We're going to work towards this in three phases. First, the localization team and the l10n drivers will look at the market for the language and come up with a good set of search providers. Locale team, we'll need your input on this, the guidelines for making recommendations are on <https://developer.mozilla.org/en-US/docs/Productization_guide>. For en-US, we currently use this set, to which we can fall back in the case of lacking localized alternatives: > Google (mobile version), Yahoo, Bing, Amazon, Twitter, Wikipedia (slightly different to desktop, 32x32 icon) We may also want to go with just a subset of the en-US engines, if that's more appropriate for the local market. Once we decide to use a particular search engine (and we test it on a mobile device), l10n drivers will contact the owner and ask for permission in the cases where it's needed, and for specifics like proper search flags. Locale team, if this is needed we'll likely need your help to at least get the contact information. For search engines that we already ship with on desktop and that you would like to include in mobile as well, the permission is not needed. Consider using a mobile version of the engine if one is available. Also, please make yourself familiar with instructions regarding the <Description/> element at <https://wiki.mozilla.org/L10n:Integrated_Search_Instructions>. For mobile, we'll want 64x64 size images, too. Once we have a specification on what the search engines for your locale should look like, Delphine and the localization team will work on an implementation on that. Delphine will create and attach patches for the desired changes and get them reviewed. After a successful review, :delphine will land them. Locale team, if you're interested, you could create the patches, too. You'd ask :delphine for review on those before landing. Please don't commit any modifications in browser/searchplugins to the hg repository without a patch reviewed by Delphine or someone else appointed by the l10n drivers. The data here is sensitive to users and our search partners, thus the extra care here. The locale team and Delphine will be driving this bug to completion.
Assignee | ||
Comment 1•6 years ago
|
||
Hey there, I see that for Desktop your team has: "google", "yahoo", "bing", "amazondotcom", "ddg", "twitter", "wikipedia-km" Would that list be better than the current one? Please let me know (note this is blocking me from going forwards with Bug 1430952) Thanks!
Flags: needinfo?(vannak.eng)
Flags: needinfo?(piseth.kheng)
Comment 2•6 years ago
|
||
Hi Delphine, Yes these are search engines we mostly used in Khmer. Please keep that for current. Thanks, Piseth
Flags: needinfo?(piseth.kheng)
Assignee | ||
Comment 3•6 years ago
|
||
Updated region.properties so it would be aligned with the more recent template we use. Did not increment value of gecko.handlerService.defaultHandlersVersion because only changed browser.contentHandlers.types.0.title=Yahoo របស់ខ្ញុំ! to browser.contentHandlers.types.0.title=My Yahoo! so assumed it was more of an udpate than a "new" handler.
Flags: needinfo?(vannak.eng)
Attachment #8947675 -
Flags: review?(francesco.lodolo)
Assignee | ||
Comment 4•6 years ago
|
||
Note: * checked list.json and wikipedia-km.xml first. No updates are needed there * talked with team by email and they confirmed they wanted to keep the current mobile ones that were already present (in case it's not clear from this thread)
Assignee: nobody → lebedel.delphine
Comment 5•6 years ago
|
||
Comment on attachment 8947675 [details] [diff] [review] bug1430960.patch Looks good, pushed directly https://hg.mozilla.org/l10n-central/km/rev/b8d5b7eda5b3b4b3f22b89a832b24684c3a09fda
Attachment #8947675 -
Flags: review?(francesco.lodolo) → review+
Updated•6 years ago
|
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Comment 6•6 years ago
|
||
Hi, let me know if you need me to test before launch.
You need to log in
before you can comment on or make changes to this bug.
Description
•