1430973 - Add a regression test for bug 1428538

Status: RESOLVED FIXED

(Core :: Security: PSM, enhancement)

Description

[Masatoshi Kimura [:emk]]

Since bug 1428538 is already closed, a new separate bug would be more preferable to make the bug-tracking clearer.

Comment 1

[Henrik Skupin (:whimboo) [⌚️UTC+1]]

Masatoshi, which files should be affected here? Also which exact steps should be done to test that data is still present?

Comment 2

[Masatoshi Kimura [:emk]]

${ProfileDir}\cert9.db and ${ProfileDir}\key4.db. See attachment 8942409 [details] [diff] [review] about a proposed test.

Comment 3

[Masatoshi Kimura [:emk]]

Attachment: Bug 1430973 - Reression test to make sure non-ASCII file paths work.

Review commit: https://reviewboard.mozilla.org/r/215930/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/215930/

Comment 4

[Dana Keeler (she/her) (use needinfo) (:keeler for reviews)]

Comment on attachment 8945826 [details]
Bug 1430973 - Reression test to make sure non-ASCII file paths work.

https://reviewboard.mozilla.org/r/215930/#review221788

LGTM, but please add a comment in the test explaining what it's for.

::: security/manager/ssl/tests/unit/test_nonascii_path.js:19
(Diff revision 1)
> +file.initWithPath(profd);
> +file.append("'÷1");
> +env.set("XPCSHELL_TEST_PROFILE_DIR", file.path);
> +
> +file = do_get_profile(); // must be called before getting nsIX509CertDB
> +Assert.ok(/[^\x20-\x7f]/.test(file.path), "the profile path should contain an non-ASCII character");

nit: "a non-ASCII character"

Comment 5

[Masatoshi Kimura [:emk]]

Comment on attachment 8945826 [details]
Bug 1430973 - Reression test to make sure non-ASCII file paths work.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/215930/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3400bd30ef04
Reression test to make sure non-ASCII file paths work. r=keeler

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/3400bd30ef04