Add a regression test for bug 1428538

RESOLVED FIXED in Firefox 60

Status

()

Core
Security: PSM
RESOLVED FIXED
a month ago
25 days ago

People

(Reporter: emk, Assigned: emk)

Tracking

(Blocks: 1 bug)

Trunk
mozilla60
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox60 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a month ago
Since bug 1428538 is already closed, a new separate bug would be more preferable to make the bug-tracking clearer.
(Assignee)

Updated

a month ago
Blocks: 1423897
Masatoshi, which files should be affected here? Also which exact steps should be done to test that data is still present?
Flags: needinfo?(VYV03354)
(Assignee)

Comment 2

a month ago
${ProfileDir}\cert9.db and ${ProfileDir}\key4.db. See attachment 8942409 [details] [diff] [review] about a proposed test.
Flags: needinfo?(VYV03354)
Comment hidden (mozreview-request)

Comment 4

28 days ago
mozreview-review
Comment on attachment 8945826 [details]
Bug 1430973 - Reression test to make sure non-ASCII file paths work.

https://reviewboard.mozilla.org/r/215930/#review221788

LGTM, but please add a comment in the test explaining what it's for.

::: security/manager/ssl/tests/unit/test_nonascii_path.js:19
(Diff revision 1)
> +file.initWithPath(profd);
> +file.append("'÷1");
> +env.set("XPCSHELL_TEST_PROFILE_DIR", file.path);
> +
> +file = do_get_profile(); // must be called before getting nsIX509CertDB
> +Assert.ok(/[^\x20-\x7f]/.test(file.path), "the profile path should contain an non-ASCII character");

nit: "a non-ASCII character"
Attachment #8945826 - Flags: review?(dkeeler) → review+
Comment hidden (mozreview-request)
(Assignee)

Updated

27 days ago
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED

Comment 6

27 days ago
Pushed by VYV03354@nifty.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/3400bd30ef04
Reression test to make sure non-ASCII file paths work. r=keeler

Comment 7

26 days ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3400bd30ef04
Status: ASSIGNED → RESOLVED
Last Resolved: 26 days ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
(Assignee)

Updated

25 days ago
Depends on: 1433903
You need to log in before you can comment on or make changes to this bug.