Rename nsINode::IndexOf to nsINode::IndexOf_Slow

RESOLVED FIXED in Firefox 60

Status

()

enhancement
P2
normal
RESOLVED FIXED
2 years ago
5 months ago

People

(Reporter: baku, Assigned: baku)

Tracking

58 Branch
mozilla60
Points:
---

Firefox Tracking Flags

(firefox60 fixed)

Details

Attachments

(1 attachment)

As part of bug 1425440 we must rename nsINode::IndexOf() and get rid of it as much as we can.
Posted patch indexOf.patchSplinter Review
Attachment #8943124 - Flags: review?(catalin.badea392)
Priority: -- → P2
Comment on attachment 8943124 [details] [diff] [review]
indexOf.patch

Review of attachment 8943124 [details] [diff] [review]:
-----------------------------------------------------------------

This is breaking the coding style and we're not deprecating this. IndexOfSlow or ComputeIndexOf? .. or ComputeIndexSlow?

r+ with a name that's camelCase.
Attachment #8943124 - Flags: review?(catalin.badea392) → review+
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/149124e4fde9
Rename nsINode::IndexOf to nsINode::ComputeIndexOf, r=catalinb
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/98c901dc8ae2
Rename nsINode::IndexOf to nsINode::ComputeIndexOf, r=me CLOSED TREE
https://hg.mozilla.org/mozilla-central/rev/149124e4fde9
https://hg.mozilla.org/mozilla-central/rev/98c901dc8ae2
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.