Closed Bug 1431000 Opened 2 years ago Closed 9 months ago

Replace the use of nsINode::InsertChildAt_Deprecated with nsINode::InsertChildBefore

Categories

(Core :: DOM: Core & HTML, enhancement, P2)

58 Branch
enhancement

Tracking

()

RESOLVED FIXED

People

(Reporter: baku, Assigned: baku)

References

Details

Attachments

(10 files)

+++ This bug was initially created as a clone of Bug #1430998 +++

I basically removed all the use of nsINode::InsertChildAt(). But the first step is to rename this method to something else in order to avoid new usage.
Attachment #8943127 - Flags: review?(catalin.badea392)
Attachment #8943128 - Flags: review?(catalin.badea392)
Attachment #8943129 - Flags: review?(catalin.badea392)
Attachment #8943131 - Flags: review?(catalin.badea392)
Attached patch part 5 - nsINodeSplinter Review
Attachment #8943133 - Flags: review?(catalin.badea392)
Attachment #8943134 - Flags: review?(catalin.badea392)
Attachment #8943135 - Flags: review?(catalin.badea392)
Attachment #8943136 - Flags: review?(catalin.badea392)
Attachment #8943137 - Flags: review?(catalin.badea392)
Priority: -- → P2
Attachment #8943346 - Flags: review?(catalin.badea392)
Attachment #8943127 - Flags: review?(catalin.badea392) → review+
Attachment #8943128 - Flags: review?(catalin.badea392) → review+
Attachment #8943129 - Flags: review?(catalin.badea392) → review+
Attachment #8943131 - Flags: review?(catalin.badea392) → review+
Attachment #8943133 - Flags: review?(catalin.badea392) → review+
Attachment #8943134 - Flags: review?(catalin.badea392) → review+
Attachment #8943135 - Flags: review?(catalin.badea392) → review+
Attachment #8943136 - Flags: review?(catalin.badea392) → review+
Comment on attachment 8943346 [details] [diff] [review]
part 10 - XULDocument - part 2

Review of attachment 8943346 [details] [diff] [review]:
-----------------------------------------------------------------

This is great.
Attachment #8943346 - Flags: review?(catalin.badea392) → review+
Comment on attachment 8943137 [details] [diff] [review]
part 9 - doInsertChildAt

Review of attachment 8943137 [details] [diff] [review]:
-----------------------------------------------------------------

I don't think we need to take this because it just moves the IndexOf call further
down the call tree and doInsertChildAt is going to be removed anyway. Do you
think there's a benefit to landing this earlier?
Attachment #8943137 - Flags: review?(catalin.badea392) → review-
> I don't think we need to take this because it just moves the IndexOf call
> further
> down the call tree and doInsertChildAt is going to be removed anyway. Do you
> think there's a benefit to landing this earlier?

I just don't want to merge the 2 patches. They will land at the same time.
Keywords: leave-open
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7cb6f03b1dc6
Introduce nsINode::InsertChildBefore, r=catalinb
https://hg.mozilla.org/integration/mozilla-inbound/rev/2d6587b85cb2
Replace the use of nsINode::InsertChildAt_Deprecated with nsINode::InsertChildBefore in nsDocument, r=catalinb
https://hg.mozilla.org/integration/mozilla-inbound/rev/9b41ab45ca5e
Replace the use of nsINode::InsertChildAt_Deprecated with nsINode::InsertChildBefore in nsGenericDOMDataNode, r=catalinb
https://hg.mozilla.org/integration/mozilla-inbound/rev/acce722528b1
Replace the use of nsINode::InsertChildAt_Deprecated with nsINode::InsertChildBefore in nsHtml5TreeOperation, r=catalinb
https://hg.mozilla.org/integration/mozilla-inbound/rev/8c803c6125e9
Replace the use of nsINode::InsertChildAt_Deprecated with nsINode::InsertChildBefore in nsHTMLContentSink, r=catalinb
https://hg.mozilla.org/integration/mozilla-inbound/rev/44096484aa87
Replace the use of nsINode::InsertChildAt_Deprecated with nsINode::InsertChildBefore in XULDocument - part 1, r=catalinb
https://hg.mozilla.org/integration/mozilla-inbound/rev/c1326aff9503
Replace the use of nsINode::InsertChildAt_Deprecated with nsINode::InsertChildBefore in XULDocument - part 2, r=catalinb
The leave-open keyword is there and there is no activity for 6 months.
:baku, maybe it's time to close this bug?
Flags: needinfo?(amarchesini)
Done.
Status: NEW → RESOLVED
Closed: 9 months ago
Flags: needinfo?(amarchesini)
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.