1431000 - Replace the use of nsINode::InsertChildAt_Deprecated with nsINode::InsertChildBefore

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P2)

Description

[Andrea Marchesini [:baku]]

+++ This bug was initially created as a clone of Bug #1430998 +++

I basically removed all the use of nsINode::InsertChildAt(). But the first step is to rename this method to something else in order to avoid new usage.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: part 1 - InsertChildBefore

Comment 2

[Andrea Marchesini [:baku]]

Attachment: part 2 - nsDocument

Comment 3

[Andrea Marchesini [:baku]]

Attachment: part 3 - nsGenericDOMDataNode

Comment 4

[Andrea Marchesini [:baku]]

Attachment: part 4 - nsHtml5TreeOperation

Comment 5

[Andrea Marchesini [:baku]]

Attachment: part 5 - nsINode

Comment 6

[Andrea Marchesini [:baku]]

Attachment: part 6 - nsHTMLContentSink

Comment 7

[Andrea Marchesini [:baku]]

Attachment: part 7 - XULDocument

Comment 8

[Andrea Marchesini [:baku]]

Attachment: part 8 - Get rid of InsertChildAt

Comment 9

[Andrea Marchesini [:baku]]

Attachment: part 9 - doInsertChildAt

Comment 10

[Andrea Marchesini [:baku]]

Attachment: part 10 - XULDocument - part 2

Comment 11

[Cătălin Badea (:catalinb)]

Comment on attachment 8943346 [details] [diff] [review]
part 10 - XULDocument - part 2

Review of attachment 8943346 [details] [diff] [review]:
-----------------------------------------------------------------

This is great.

Comment 12

[Cătălin Badea (:catalinb)]

Comment on attachment 8943137 [details] [diff] [review]
part 9 - doInsertChildAt

Review of attachment 8943137 [details] [diff] [review]:
-----------------------------------------------------------------

I don't think we need to take this because it just moves the IndexOf call further
down the call tree and doInsertChildAt is going to be removed anyway. Do you
think there's a benefit to landing this earlier?

Comment 13

[Andrea Marchesini [:baku]]

> I don't think we need to take this because it just moves the IndexOf call
> further
> down the call tree and doInsertChildAt is going to be removed anyway. Do you
> think there's a benefit to landing this earlier?

I just don't want to merge the 2 patches. They will land at the same time.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7cb6f03b1dc6
Introduce nsINode::InsertChildBefore, r=catalinb
https://hg.mozilla.org/integration/mozilla-inbound/rev/2d6587b85cb2
Replace the use of nsINode::InsertChildAt_Deprecated with nsINode::InsertChildBefore in nsDocument, r=catalinb
https://hg.mozilla.org/integration/mozilla-inbound/rev/9b41ab45ca5e
Replace the use of nsINode::InsertChildAt_Deprecated with nsINode::InsertChildBefore in nsGenericDOMDataNode, r=catalinb
https://hg.mozilla.org/integration/mozilla-inbound/rev/acce722528b1
Replace the use of nsINode::InsertChildAt_Deprecated with nsINode::InsertChildBefore in nsHtml5TreeOperation, r=catalinb
https://hg.mozilla.org/integration/mozilla-inbound/rev/8c803c6125e9
Replace the use of nsINode::InsertChildAt_Deprecated with nsINode::InsertChildBefore in nsHTMLContentSink, r=catalinb
https://hg.mozilla.org/integration/mozilla-inbound/rev/44096484aa87
Replace the use of nsINode::InsertChildAt_Deprecated with nsINode::InsertChildBefore in XULDocument - part 1, r=catalinb
https://hg.mozilla.org/integration/mozilla-inbound/rev/c1326aff9503
Replace the use of nsINode::InsertChildAt_Deprecated with nsINode::InsertChildBefore in XULDocument - part 2, r=catalinb

Comment 15

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/7cb6f03b1dc6
https://hg.mozilla.org/mozilla-central/rev/2d6587b85cb2
https://hg.mozilla.org/mozilla-central/rev/9b41ab45ca5e
https://hg.mozilla.org/mozilla-central/rev/acce722528b1
https://hg.mozilla.org/mozilla-central/rev/8c803c6125e9
https://hg.mozilla.org/mozilla-central/rev/44096484aa87
https://hg.mozilla.org/mozilla-central/rev/c1326aff9503

Comment 16

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:baku, maybe it's time to close this bug?

Comment 17

[Andrea Marchesini [:baku]]

Done.