1431010 - Improve ref-counting of MDSM::Request{Audio,Video}Data

Status: NEW

(Core :: Audio/Video: Playback, enhancement, P5)

Description

[JW Wang [:jwwang] [:jw_wang]]

We should pass a RefPtr<> instead of a raw pointer so we can transfer ownership without additional AddRef/Release whenever possible.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1431010. P1 - pass RefPtr<> instead of a raw pointer so we can transfer ownership whenever possible.

Review commit: https://reviewboard.mozilla.org/r/213808/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/213808/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1431010. P2 - add an overload of Push() to MediaQueue to support ownership transfer.

Review commit: https://reviewboard.mozilla.org/r/213810/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/213810/

Comment 3

[Tzuhao Kuo [:kaku]]

Comment on attachment 8943465 [details]
Bug 1431010. P1 - pass RefPtr<> instead of a raw pointer so we can transfer ownership whenever possible.

https://reviewboard.mozilla.org/r/213808/#review219564

Comment 4

[Tzuhao Kuo [:kaku]]

Comment on attachment 8943466 [details]
Bug 1431010. P2 - add an overload of Push() to MediaQueue to support ownership transfer.

https://reviewboard.mozilla.org/r/213810/#review219566

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.