Closed
Bug 1431015
Opened 6 years ago
Closed 6 years ago
Intermittent js/src/jit-test/tests/self-test/assertRecoveredOnBailout-1.js | Timeout (code -6, args "--baseline-eager") [150.1 s]
Categories
(Core :: JavaScript Engine, defect, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: intermittent-bug-filer, Assigned: tcampbell)
Details
(Keywords: intermittent-failure, Whiteboard: [stockwell fixed:other])
Attachments
(1 file)
932 bytes,
patch
|
nbp
:
review+
|
Details | Diff | Splinter Review |
Filed by: csabou [at] mozilla.com https://treeherder.mozilla.org/logviewer.html#?job_id=156785548&repo=autoland https://queue.taskcluster.net/v1/task/ezPBC6zNQ_ieWuMc-dLn2A/runs/0/artifacts/public/logs/live_backing.log
Comment 1•6 years ago
|
||
Here's a part of the log: [task 2018-01-17T05:54:00.428Z] TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/self-test/assertRecoveredOnBailout-1.js | Timeout (code -6, args "--baseline-eager") [150.1 s] [task 2018-01-17T05:54:00.428Z] {"action": "test_start", "pid": 5684, "source": "jittests", "test": "self-test/assertRecoveredOnBailout-1.js", "thread": "main", "time": 1516168290.3460338} [task 2018-01-17T05:54:00.428Z] {"action": "test_end", "extra": {"jitflags": "--baseline-eager"}, "message": "Timeout", "pid": 5684, "source": "jittests", "status": "FAIL", "test": "self-test/assertRecoveredOnBailout-1.js", "thread": "main", "time": 1516168440.428532} [task 2018-01-17T05:54:00.428Z] INFO exit-status : -6 [task 2018-01-17T05:54:00.428Z] INFO timed-out : 0:00:00.082500 [task 2018-01-17T05:54:00.428Z] FAILURES: [task 2018-01-17T05:54:00.428Z] TIMEOUTS: [task 2018-01-17T05:54:00.428Z] --baseline-eager self-test/assertRecoveredOnBailout-1.js [task 2018-01-17T05:54:00.428Z] Result summary: [task 2018-01-17T05:54:00.428Z] Passed: 28406 [task 2018-01-17T05:54:00.428Z] Failed: 1 [task 2018-01-17T05:54:00.428Z] {"action": "suite_end", "pid": 5684, "source": "jittests", "thread": "main", "time": 1516168440.428698} [task 2018-01-17T05:54:00.459Z] Makefile:73: recipe for target 'check-jit-test' failed [task 2018-01-17T05:54:00.459Z] make[1]: *** [check-jit-test] Error 2 [task 2018-01-17T05:54:00.459Z] make[1]: Leaving directory '/builds/worker/workspace/build/src/obj-spider/js/src' [task 2018-01-17T05:54:00.460Z] Makefile:352: recipe for target 'check-jit-test' failed [task 2018-01-17T05:54:00.460Z] make: *** [check-jit-test] Error 2
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 4•6 years ago
|
||
Can you take a look, Nicolas? Seems the assertRecoveredOnBailout-1.js test gets stuck in it's loop sometimes.
Flags: needinfo?(nicolas.b.pierron)
Comment hidden (Intermittent Failures Robot) |
Comment 6•6 years ago
|
||
In the last 7 days we have 32 failures. They occur on Linux x64 and the affected builds type are debug and opt. Recent log failure: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=160500146&lineNumber=88485 and a relevant part of it [task 2018-02-05T23:14:30.645Z] TIMEOUT - self-test/assertRecoveredOnBailout-1.js 88485 [task 2018-02-05T23:14:30.645Z] TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/self-test/assertRecoveredOnBailout-1.js | Timeout (code -6, args "--baseline-eager") [150.1 s] 88486 [task 2018-02-05T23:14:30.645Z] {"action": "test_start", "pid": 5684, "source": "jittests", "test": "self-test/assertRecoveredOnBailout-1.js", "thread": "main", "time": 1517872320.552209} 88487 [task 2018-02-05T23:14:30.645Z] {"action": "test_end", "extra": {"jitflags": "--baseline-eager"}, "message": "Timeout", "pid": 5684, "source": "jittests", "status": "FAIL", "test": "self-test/assertRecoveredOnBailout-1.js", "thread": "main", "time": 1517872470.645546} 88488 [task 2018-02-05T23:14:30.645Z] INFO exit-status : -6 88489 [task 2018-02-05T23:14:30.645Z] INFO timed-out : 0:00:00.093340 88490 [task 2018-02-05T23:14:30.645Z] FAILURES: 88491 [task 2018-02-05T23:14:30.645Z] TIMEOUTS: 88492 [task 2018-02-05T23:14:30.645Z] --baseline-eager self-test/assertRecoveredOnBailout-1.js 88493 [task 2018-02-05T23:14:30.645Z] Result summary: 88494 [task 2018-02-05T23:14:30.645Z] Passed: 28467 88495 [task 2018-02-05T23:14:30.645Z] Failed: 1 88496 [task 2018-02-05T23:14:30.646Z] {"action": "suite_end", "pid": 5684, "source": "jittests", "thread": "main", "time": 1517872470.645799} 88497 [task 2018-02-05T23:14:30.680Z] Makefile:73: recipe for target 'check-jit-test' failed 88498 [task 2018-02-05T23:14:30.680Z] make[1]: *** [check-jit-test] Error 2 88499 [task 2018-02-05T23:14:30.680Z] make[1]: Leaving directory '/builds/worker/workspace/build/src/obj-spider/js/src' 88500 [task 2018-02-05T23:14:30.680Z] Makefile:352: recipe for target 'check-jit-test' failed 88501 [task 2018-02-05T23:14:30.680Z] make: *** [check-jit-test] Error 2 88502 [task 2018-02-05T23:14:30.917Z] path[0]->predecessor() = 'a' :nbp, can you please have a look at this?
Whiteboard: [stockwell needswork]
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 8•6 years ago
|
||
Disable off-thread Ion compile for this test. This adds a lot of machine speed related indeterminacy and likely the cause of the intermittent.
Flags: needinfo?(nicolas.b.pierron)
Attachment #8950241 -
Flags: review?(nicolas.b.pierron)
Comment 9•6 years ago
|
||
Comment on attachment 8950241 [details] [diff] [review] 0001-Bug-1431015-Make-assertRecoverdOnBailout-test-more-p.patch Review of attachment 8950241 [details] [diff] [review]: ----------------------------------------------------------------- I do not understand why this would be necessary. Thus, I fear that this is a miss-placed temporary work-around. I would prefer to understand why we have these timeouts, and use this patch if this is becoming too much of a burden until we figure it out.
Attachment #8950241 -
Flags: review?(nicolas.b.pierron) → review+
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 11•6 years ago
|
||
Looks like it we try the modified test or it gets disabled. Requesting checkin.
Assignee: nobody → tcampbell
Keywords: checkin-needed,
leave-open
Comment 12•6 years ago
|
||
Pushed by archaeopteryx@coole-files.de: https://hg.mozilla.org/integration/mozilla-inbound/rev/af6635d0a52a Make assertRecoverdOnBailout test more predictable r=nbp
Keywords: checkin-needed
Comment 13•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/af6635d0a52a
Updated•6 years ago
|
Whiteboard: [stockwell disable-recommended] → [stockwell fixed:other]
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 15•6 years ago
|
||
Looking at the orangefactor graphs, it seems the patched test solved the intermittent problem. It remains unclear why off-thread compile starting becoming a problem for this test in January.
Priority: P5 → P3
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Updated•6 years ago
|
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Keywords: leave-open
You need to log in
before you can comment on or make changes to this bug.
Description
•