Closed
Bug 1431020
Opened 6 years ago
Closed 6 years ago
Remove unused globals TLS_ERROR_REPORT_TELEMETRY_MANUAL_SEND and TLS_ERROR_REPORT_TELEMETRY_AUTO_SEND
Categories
(Firefox :: General, enhancement)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(1 file)
Bug 1241455 removed the usages of TLS_ERROR_REPORT_TELEMETRY_MANUAL_SEND and TLS_ERROR_REPORT_TELEMETRY_AUTO_SEND but didn't remove the globals themselves. We're trying to clean up the global scope of browser.js a bit, so since these are unused, we should remove them.
| Comment hidden (mozreview-request) |
|
||
Comment 2•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8943154 [details] Bug 1431020 - Remove unused globals TLS_ERROR_REPORT_TELEMETRY_MANUAL_SEND and TLS_ERROR_REPORT_TELEMETRY_AUTO_SEND. https://reviewboard.mozilla.org/r/213500/#review219260 The change looks good, but I would go a bit further: - https://searchfox.org/mozilla-central/rev/48cbb200aa027a0a379b6004b6196a167344b865/browser/base/content/content.js#73-74 seems similarly unused. - I don't think these consts (including PREF_SSL_IMPACT_ROOTS) should be defined in the global scope.
Attachment #8943154 -
Flags: review?(florian) → review+
| Comment hidden (mozreview-request) |
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4d1b4a410e55 Remove unused globals TLS_ERROR_REPORT_TELEMETRY_MANUAL_SEND and TLS_ERROR_REPORT_TELEMETRY_AUTO_SEND. r=florian
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/4d1b4a410e55
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
You need to log in
before you can comment on or make changes to this bug.
Description
•