1431049 - [Wayland] Crash when there is no keyboard

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[Martin Stránský [:stransky] (ni? me)]

Downstream report: https://bugzilla.redhat.com/show_bug.cgi?id=1505745

By Takuro Ashie:

I found an issue that some uninitialized variable are used in nsClipboardWayland.cpp of Firefox on Wayland. It will causes crash when no keyboard presents. Please see the attached patch for more detail.

The crash is reproduced on my embedded board but not confirmed on Fedora yet.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: 0001-Wayland-Fix-a-crash-which-causes-when-there-is-no-ke.patch

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1431049 - don't crash when keyboard is not present, based on patch by Takuro Ashie.

Review commit: https://reviewboard.mozilla.org/r/214250/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/214250/

Comment 3

[Jan Horak [:jhorak]]

Comment on attachment 8943890 [details]
Bug 1431049 - don't crash when keyboard is not present, based on patch by Takuro Ashie.

https://reviewboard.mozilla.org/r/214250/#review220178

::: widget/gtk/nsClipboardWayland.cpp:295
(Diff revision 1)
>      static auto sGdkWaylandDisplayGetWlDisplay =
>          (wl_display *(*)(GdkDisplay *))
>          dlsym(RTLD_DEFAULT, "gdk_wayland_display_get_wl_display");
>  
>      mDisplay = sGdkWaylandDisplayGetWlDisplay(gdk_display_get_default());
>      wl_registry_add_listener(wl_display_get_registry(mDisplay),

Please emphatize how mSeat is initialized (since it is set to nullptr in the constructor) and what's the purpse of double call of wl_display_roundtrip.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 8943890 [details]
Bug 1431049 - don't crash when keyboard is not present, based on patch by Takuro Ashie.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/214250/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f821cb905c0b
don't crash when keyboard is not present, based on patch by Takuro Ashie. r=jhorak

Comment 6

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/f821cb905c0b