Closed Bug 1431072 Opened 2 years ago Closed 2 years ago

Move a duplicate declarations (NS_NPAPIPLUGIN_CALLBACK) into a common file

Categories

(Core :: IPC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: Sylvestre, Assigned: Sylvestre)

Details

Attachments

(1 file)

#define NS_NPAPIPLUGIN_CALLBACK(_type, _name) _type (__stdcall * _name)
and co are defined twice in the source code.

https://dxr.mozilla.org/mozilla-central/source/dom/plugins/ipc/PluginModuleChild.h#37
https://dxr.mozilla.org/mozilla-central/source/dom/plugins/base/nsNPAPIPlugin.h#17

As both includes "npfunctions.h", I propose to move the declaration into this single place.
Comment on attachment 8943237 [details]
Bug 1431072 - Move a duplicate declarations (NS_NPAPIPLUGIN_CALLBACK) into a common file

https://reviewboard.mozilla.org/r/213564/#review219362
Attachment #8943237 - Flags: review?(jmathies) → review+
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/42523af3da9d
Move a duplicate declarations (NS_NPAPIPLUGIN_CALLBACK) into a common file r=jimm
https://hg.mozilla.org/mozilla-central/rev/42523af3da9d
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.