Closed Bug 1431129 Opened 2 years ago Closed 2 years ago

ESLint rule definitions for no-mixed-spaces-and-tabs and no-tabs overlap badly

Categories

(Firefox Build System :: Lint and Formatting, enhancement)

3 Branch
enhancement
Not set

Tracking

(firefox59 fixed)

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: standard8, Assigned: standard8)

Details

Attachments

(1 file)

Currently in recommended.js we have:

"no-mixed-spaces-and-tabs": ["error", "smart-tabs"]
"no-tabs": "error"

Seeing as we don't want tabs at all, we should drop the smart-tabs option to the first - it isn't necessary and just confuses if people look at the rules.
Thinking about it, we can just drop no-mixed-spaces-and-tabs (and avoid the overhead), as no-tabs will do what we want anyway.
Comment on attachment 8943549 [details]
Bug 1431129 - Remove no-mixed-spaces-and-tabs from the ESLint config, since no-tabs disallows tabs anyway. .

https://reviewboard.mozilla.org/r/213900/#review219862
Attachment #8943549 - Flags: review?(dtownsend) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b7899ec5d5f8
Remove no-mixed-spaces-and-tabs from the ESLint config, since no-tabs disallows tabs anyway. r=mossop.
https://hg.mozilla.org/mozilla-central/rev/b7899ec5d5f8
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Product: Testing → Firefox Build System
Version: Version 3 → 3 Branch
You need to log in before you can comment on or make changes to this bug.