1431149 - Add an optional schema name argument to `OpenedConnection#{get, set}SchemaVersion`

Status: RESOLVED FIXED

(Toolkit :: Storage, enhancement)

Description

[Lina Butler [:lina]]

This would let us set the schema version on attached databases, as we do in bug 1305563.

Comment 1

[Lina Butler [:lina]]

Attachment: Bug 1431149 - Add an optional schema name argument to `OpenedConnection#{get, set}SchemaVersion`.

Review commit: https://reviewboard.mozilla.org/r/213640/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/213640/

Comment 2

[Lina Butler [:lina]]

I thought about validating the schema name, but the official grammar for SQL identifiers is complicated, with quoting rules and whatnot. We could either use a simple RegExp that only allows alphanumeric schema names, or leave it and assume that callers know what they're doing. Since it's an optional argument with one consumer, I'm thinking we leave it.

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 8943322 [details]
Bug 1431149 - Add an optional schema name argument to `OpenedConnection#{get, set}SchemaVersion`.

https://reviewboard.mozilla.org/r/213640/#review219646

Thanks

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/410a941bdce8
Add an optional schema name argument to `OpenedConnection#{get, set}SchemaVersion`. r=mak

Comment 5

[Dorel Luca [:dluca]]

Backed out changeset 410a941bdce8 (bug 1431149) for devtools failure on toolkit/components/passwordmgr/test/mochitest/test_basic_form_autocomplete.html

https://treeherder.mozilla.org/logviewer.html#?job_id=157165048&repo=autoland&lineNumber=24491

https://hg.mozilla.org/integration/autoland/rev/f8230d6dd54f00b3439e5a587499255e29f9ebd9

https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=410a941bdce8c11ec1da55d6cc541b93a93dda5c

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9e512081bde6
Add an optional schema name argument to `OpenedConnection#{get, set}SchemaVersion`. r=mak

Comment 7

[Dorel Luca [:dluca]]

Backout by mistake and relanded.

Comment 8

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/9e512081bde6