14312 - problem with populating an empty html select object

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P3)

Description

[(not reading, please use [e-mail] instead)]

in compose, we have a html select object for the "From" identity.

it is built up using js.

(see mozilla/mailnews/compose/resources/content/MsgComposeCommands.js and
mozilla/mailnews/compose/resources/content/messengercompose.xul)

on linux (possible other platforms), I have problems getting to the options
(after they are added via js) and when I do choose one, the select object
doesn't change.

I do have a work around that I checked in to the tree.

the work around is to have a fake html option in the select widget at start up,
add the identities to it, and then remove the fake option

I've checked this work around in.  look in
mozilla/mailnews/compose/resources/content/MsgComposeCommands.js and
mozilla/mailnews/compose/resources/content/messengercompose.xul for this bug
number

Comment 1

[(not reading, please use [e-mail] instead)]

work around now checked in.

Comment 2

[Alec Flett]

Adding shaver for triage because this is a big DOM problem...you can't have the
widget adding extra fake options!

Comment 3

[lchiang]

cc: beppe since DOM is mentioned here.

Comment 4

[Alec Flett]

This is now also affecting the Copies pane in the Account Setup dialog... that
widget is populated via a template.

Comment 5

[David :Bienvenu]

and the imap delete model preference in the account setup.

Comment 6

[Chris Waterson]

i'll take a look at this one. sspitzer: does this happen with straight ole'
HTML?

Comment 7

[Chris Waterson]

Attachment: test case

Comment 8

[Chris Waterson]

sspitzer: I just ran the attached HTMLtest case in viewer; it seems to work
fine (modulo an assertion in nsListControlFrame::UpdateSelection). Gonna try
this in XUL, next...

Comment 9

[Chris Waterson]

Attachment: xul test case

Comment 10

[Chris Waterson]

ok, the attached XUL test case seems to work fine as well. so what is mailnews
doing different?

Comment 11

[(not reading, please use [e-mail] instead)]

waterson, I'll try to remove the work around
in mozilla/mailnews/compose/resources/content/MsgComposeCommands.js and
mozilla/mailnews/compose/resources/content/messengercompose.xul and see if it
works.

if so, I'll mark this bug fixed and remove the work around.

Comment 12

[Chris Waterson]

sspitzer: i do notice that the -second- time you display the message dialog, it
always reverts to "foo". Is that because of changes I have in my tree? or is it
universal?

Comment 13

[(not reading, please use [e-mail] instead)]

I'm not seeing what you are seeing, so it might be your tree.

When I remove the work around, it works fine for me.

I'll check in the change as soon as the tree opens and mark this fixed.

Comment 14

[(not reading, please use [e-mail] instead)]

marking fixed, work around removed and checked in.

Comment 15

[lchiang]

candice has kindly offered to help verify bugs.

Comment 16

[Karen Huang]

Lisa, do you mean to let Candice Huang(chuang) to verify this bug?
I will be glad to verify this bug, too.
But I need to verify for Dogfood and M12 bugs before this one since this bug's
milestone is M13 ....

Comment 17

[Karen Huang]

After read this bug, I am thinking that Lisa maybe change QA contact to me
(wrong person)....it should be chuang (Candice Huang) since this bug need
developer or the debugger to verify... change QA contact to chuang based on
Lisa's comments initially.

Comment 18

[chuang]

Veirfied on 1999-12-16-12-M12 Win32, Linux build and 1999-12-16-09-M12 Mac
build, the "From" select object appears fine.  Check in the xul file, there's no
html option for work around.