1431201 - Crash in java.lang.NullPointerException: NativeException NullHandle() [T = nsWindow::GeckoViewSupport] at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)

Status: RESOLVED FIXED

(GeckoView :: General, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

+++ This bug was initially created as a clone of Bug #1427079 +++

This bug was filed from the Socorro interface and is
report bp-b960de08-e64c-495c-bada-7afaf0171226.
=============================================================

Top 10 frames of crashing thread:

0 libxul.so mozilla::jni::detail::ProxyNativeCall<nsWindow::GeckoViewSupport, mozilla::java::GeckoSession::Window, false, true, const mozilla::jni::Ref<mozilla::jni::Object, _jobject*>&, const mozilla::jni::Ref<mozilla::jni::Object, _jobject*>&>::Call<false, true, 0, 1> widget/android/jni/Natives.h:427
1 libxul.so mozilla::jni::detail::ProxyNativeCall<nsWindow::GeckoViewSupport, mozilla::java::GeckoSession::Window, false, true, const mozilla::jni::Ref<mozilla::jni::Object, _jobject*>&, const mozilla::jni::Ref<mozilla::jni::Object, _jobject*>&>::operator widget/android/jni/Natives.h:499
2 libxul.so nsWindow::WindowEvent<mozilla::jni::detail::ProxyNativeCall<nsWindow::GeckoViewSupport, mozilla::java::GeckoSession::Window, false, true, const mozilla::jni::Ref<mozilla::jni::Object, _jobject*>&, const mozilla::jni::Ref<mozilla::jni::Object, _jobject*>&>, false, const mozilla::jni::Ref<mozilla::java::GeckoSession::Window, _jobject*>&, nsWindow::GeckoViewSupport>::Run widget/android/nsWindow.cpp:161
3 libxul.so nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1039
4 libxul.so NS_ProcessNextEvent xpcom/threads/nsThreadUtils.cpp:510
5 libxul.so nsThreadManager::SpinEventLoopUntil xpcom/threads/nsThreadUtils.h:323
6 libxul.so NS_InvokeByIndex 
7 libxul.so XPCWrappedNative::CallMethod js/xpconnect/src/XPCWrappedNative.cpp:1948
8 libxul.so XPC_WN_CallMethod js/xpconnect/src/XPCWrappedNativeJSOps.cpp:929
9 libxul.so js::InternalCallOrConstruct js/src/jscntxtinlines.h:291

=============================================================

these crashes start to show up in fennec 58 with crash reason "MOZ_CRASH(JNI exception)" and the following java stack trace:

java.lang.NullPointerException: NativeException NullHandle() [T = nsWindow::GeckoViewSupport]
	at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
	at org.mozilla.gecko.GeckoThread.run(GeckoThread.java:407)

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Bug 1431201 - Clear native queue when disposing window;

Dispose the native call queue when disposing a window object, so we
don't end up with stale calls in the queue that can cause crashes.

Review commit: https://reviewboard.mozilla.org/r/215330/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/215330/

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8945109 [details]
Bug 1431201 - Clear native queue when disposing window;

https://reviewboard.mozilla.org/r/215330/#review221332

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f799207b5dd9
Clear native queue when disposing window; r=snorp

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/f799207b5dd9

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Please request Beta approval on this when you get a chance. It grafts cleanly as-landed.

Comment 6

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8945109 [details]
Bug 1431201 - Clear native queue when disposing window;

Approval Request Comment
[Feature/Bug causing the regression]: N/A
[User impact if declined]: Possible crashes when backgrounding or quitting the app
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Very small change and we're at the start of release cycle
[String changes made/needed]: None

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8945109 [details]
Bug 1431201 - Clear native queue when disposing window;

Looks like this fixed the crashes in Nightly. Let's uplift for 59 beta 6.

Comment 8

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8292d441cb0c